Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Feb 2019 04:33:39 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 235879] www/e2guardian: update to 5.3.1
Message-ID:  <bug-235879-7788-vH8CmyA0IF@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-235879-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-235879-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235879

--- Comment #1 from Tobias Kortkamp <tobik@freebsd.org> ---
Comment on attachment 202182
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D202182
e2guardian 5.3.1 port update

Can you please submit unified diffs for port updates?  They are
easier to review and work with than shell archives for updates since
they show what has actually changed in the port.

+DEFAULT_VERSIONS+=3Dssl=3Dopenssl

This is wrong.  Ports can never set DEFAULT_VERSIONS.  DEFAULT_VERSIONS
is a global setting.  What version of SSL to use is for users to
decide.  It's not up to individual ports.

What problem does this solve?

+GH_ACCOUNT=3D    e2guardian

Remove this.  It's set to the default value.

+PORTVERSION=3D   5.3
...
+GH_TAGNAME=3D    v5.3.1

Why not actually set PORTVERSION=3D5.3.1 ?

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-235879-7788-vH8CmyA0IF>