Date: Tue, 20 Oct 2015 18:01:53 +0200 From: Lars Engels <lars.engels@0x20.net> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Jan Beich <jbeich@vfemail.net>, Lars Engels <lme@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r399705 - head/net-mgmt/aircrack-ng Message-ID: <20151020160153.GI66179@e-new.0x20.net> In-Reply-To: <566D251D429BE229A8507878@ogg.in.absolight.net> References: <201510191805.t9JI5mEP085148@repo.freebsd.org> <oafu-r9mo-wny@vfemail.net> <7D8DC2B6B35EA3356CFE4530@atuin.in.mat.cc> <20151020131452.GH66179@e-new.0x20.net> <566D251D429BE229A8507878@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--r4QXMf6/kyF/FvJJ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Oct 20, 2015 at 03:28:12PM +0200, Mathieu Arnold wrote:
> +--On 20 octobre 2015 15:14:52 +0200 Lars Engels <lars.engels@0x20.net>
> wrote:
> | On Tue, Oct 20, 2015 at 11:26:00AM +0200, Mathieu Arnold wrote:
> |>=20
> |>=20
> |> +--On 19 octobre 2015 20:33:35 +0200 Jan Beich <jbeich@vfemail.net>
> |> wrote:
> |> | Lars Engels <lme@FreeBSD.org> writes:
> |> |=20
> |> |> +INSTALL_TARGET=3D strip install
> |> | [...]
> |> |> -post-install:
> |> |> - @${STRIP_CMD} ${BIN_FILES:S,^,${STAGEDIR}${PREFIX}/bin/,} \
> |> |> - ${SBIN_FILES:S,^,${STAGEDIR}${PREFIX}/sbin/,}
> |> |=20
> |> | This always strips the binaries, even for WITH_DEBUG=3D1. The magic =
for
> |> | INSTALL_TARGET in bsd.port.mk only works with default automake targe=
t.
> |> |=20
> |> | Index: net-mgmt/aircrack-ng/Makefile
> |> | =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> |> | --- net-mgmt/aircrack-ng/Makefile (revision 399707)
> |> | +++ net-mgmt/aircrack-ng/Makefile (working copy)
> |> | @@ -18,7 +18,7 @@ CPE_VERSION=3D ${DISTVERSION:C/-.*//}
> |> | CPE_UPDATE=3D ${DISTVERSION:C/^[^-]*$//:C/.*-//}
> |> | DOS2UNIX_FILES=3D src/osdep/byteorder.h
> |> | MAKE_ARGS=3D experimental=3Dtrue libnl=3Dfalse prefix=3D${PREFIX}
> |> | -INSTALL_TARGET=3D strip install
> |> | +INSTALL_TARGET=3D ${STRIP:S/-s/strip/} install
> |> | USE_OPENSSL=3D yes
> |> | =20
> |> | OPTIONS_DEFINE=3D PCRE SQLITE
> |>=20
> |=20
> | Thanks Jan, I didn't think about this.
> |=20
> |=20
> |> This is harder to understand, if you don't know what STRIP is for, or
> |> what it contains, it does not make a lot of sense, the previous way was
> |> better, I feel.
> |=20
> | I think I'll just add a comment what Jan's solution to this problem
> | does.
> | The way it was before was clumy, because I had to add [S]BIN_FILES
> | variables containing all (often changing) binaries.
>=20
> You could also have run ${STRIP_CMD} ${STAGEDIR}${PREFIX}/*bin/* or
> something similar where you did not need to maintain that list :-)
No, unfortunately there are also shell scripts along "real" binaries in
those directories.
--r4QXMf6/kyF/FvJJ
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJWJmVxXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4RjQwMDE3RTRERjUzMTI1N0FGRTUxNDlF
NTRDQjM3RDNBMDg5RDZEAAoJEOVMs306CJ1t0XIH/j9SlTrPmHlNppoNd7wudLvV
K02YiFoYvGz3gLFWS++akRewkUGFSh1dsbB2myq9fR/485QdgORfR8guHgkQ9YZ2
e/H14sgfmqhSPfk3Ul03xEe0GIuyYq/eQQyKnu/kiFuq176nenpy9y3hupObeobU
PwTWlDI1mlLTEN1j5M1cgegXSdb3xMmko4g++HK/7cKEgO+I61xq/jg/epQnt2Hv
XtNLqpfGRt0ImUA9+FakXAkGEFW4ONh5Cdkw6H9VT62zD4Li+lwNFPAQpryd9IcI
SMUznrWCbFDFQu/9n9lxfh6KXahe8Q7PW6tBsss8uP1yVpI1heVMtDcbqcc/c64=
=QM8S
-----END PGP SIGNATURE-----
--r4QXMf6/kyF/FvJJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151020160153.GI66179>