From owner-freebsd-current@FreeBSD.ORG Sun Feb 1 20:46:47 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 107721065673 for ; Sun, 1 Feb 2009 20:46:47 +0000 (UTC) (envelope-from sepotvin@videotron.ca) Received: from zerofail.com (gatekeeper1.zerofail.com [208.71.11.38]) by mx1.freebsd.org (Postfix) with ESMTP id A5A298FC18 for ; Sun, 1 Feb 2009 20:46:46 +0000 (UTC) (envelope-from sepotvin@videotron.ca) Received: from telcobridges.com by freebsd.org (zerofail.com) (SecurityGateway 1.1.2) with SMTP id SG001467203.MSG for ; Sun, 01 Feb 2009 15:36:37 -0500 Received: from leia.telcobridges.com ([208.94.105.59]) by telcobridges.com with Microsoft SMTPSVC(6.0.3790.3959); Sun, 1 Feb 2009 15:36:39 -0500 Message-ID: <498607D7.7090507@videotron.ca> Date: Sun, 01 Feb 2009 15:36:39 -0500 From: "Stephane E. Potvin" User-Agent: Thunderbird 2.0.0.19 (X11/20090127) MIME-Version: 1.0 To: Ralph Zitz References: <4985FA10.5080604@imada.sdu.dk> In-Reply-To: <4985FA10.5080604@imada.sdu.dk> X-Enigmail-Version: 0.95.7 Content-Type: multipart/mixed; boundary="------------000006000800080802060307" X-OriginalArrivalTime: 01 Feb 2009 20:36:39.0867 (UTC) FILETIME=[C906B0B0:01C984AC] X-SGHeloLookup-Result: hardfail smtp.helo=telcobridges.com (does not match 208.71.8.41) X-SGOP-RefID: str=0001.0A090201.498607D8.0078,ss=2,fgs=0 (_st=2 _vt=0 _iwf=0) Cc: freebsd-current@freebsd.org Subject: Re: patch r187693 breaks HAL on amd64-current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2009 20:46:47 -0000 This is a multi-part message in MIME format. --------------000006000800080802060307 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ralph Zitz wrote: > I'm not a HAL expert, but it seems that the patch makes HAL create a > zombie process when watching /dev/cd0. Reversing the patch makes HAL > work again. > > Link to patch message: > http://lists.freebsd.org/pipermail/svn-src-all/2009-January/004073.html > Hi Ralph Try the following patch, it should fix your problem with hal. Regards Steph -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmGB9YACgkQmdOXtTCX/nt8tACgj5IzDaHDEsKIJbZPefOwzkiW Ne4AoMV4GzfMLeVeBAWIRbmG08R7Lpj3 =K7Cu -----END PGP SIGNATURE----- --------------000006000800080802060307 Content-Type: text/plain; name="lp64_select_fix.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="lp64_select_fix.diff" Index: kern/sys_generic.c =================================================================== --- kern/sys_generic.c (revision 187983) +++ kern/sys_generic.c (working copy) @@ -903,7 +903,7 @@ * bit position in the fd_mask array. */ static __inline int -selflags(fd_mask **ibits, int idx, int bit) +selflags(fd_mask **ibits, int idx, fd_mask bit) { int flags; int msk; @@ -912,7 +912,7 @@ for (msk = 0; msk < 3; msk++) { if (ibits[msk] == NULL) continue; - if ((ibits[msk][idx] & (fd_mask)bit) == 0) + if ((ibits[msk][idx] & bit) == 0) continue; flags |= select_flags[msk]; } --------------000006000800080802060307 Content-Type: application/octet-stream; name="lp64_select_fix.diff.sig" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="lp64_select_fix.diff.sig" iEYEABECAAYFAkmGB9cACgkQmdOXtTCX/nsf4gCcDVFWR3lmMVC6/G61MjPL81getI8AoOVT y6q1IMkYWZgzpZLXu0Ig9fHQ --------------000006000800080802060307--