Date: Tue, 14 May 2013 18:26:12 GMT From: Markiyan Kushnir <markiyan.kushnir@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/178640: net/svnup 0.71 seems to not respect -r option Message-ID: <201305141826.r4EIQCsb011675@oldred.FreeBSD.org> Resent-Message-ID: <201305141830.r4EIU16W007718@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 178640 >Category: ports >Synopsis: net/svnup 0.71 seems to not respect -r option >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 14 18:30:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Markiyan Kushnir >Release: 9.1-PRERELEASE >Organization: >Environment: FreeBSD mkushnir.zapto.org 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0: Sun Jan 13 16:29:49 EET 2013 root@mkushnir.zapto.org:/usr/obj/usr/RELENG_9/src/sys/MAREK amd64 >Description: The 0.71 version of svnup always checks out or updates to the latest revision regardless of the -r command line option. The "latest revision" used to and should be the default behavior in case no -r option was passed in. Seen in: # svnup -V svnup version 0.71 >How-To-Repeat: # svnup current -r 248000 Fetching revision: 250633 >Fix: Patch attached with submission follows: Only in svnup-0.71-mkushnir: svnup diff -du -r svnup-0.71/svnup.c svnup-0.71-mkushnir/svnup.c --- svnup-0.71/svnup.c 2013-05-10 03:38:09.000000000 +0300 +++ svnup-0.71-mkushnir/svnup.c 2013-05-14 09:34:05.000000000 +0300 @@ -1865,7 +1865,7 @@ /* Initialize connection with the server and get the latest revision number. */ connection.response_blocks = 10240; - connection.response_length = connection.revision = 0; + connection.response_length = 0; if ((connection.response = (char *)malloc(connection.response_blocks * BUFFER_UNIT + 1)) == NULL) err(EXIT_FAILURE, "main connection.response malloc"); >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305141826.r4EIQCsb011675>