From owner-freebsd-arm@FreeBSD.ORG  Fri Aug 29 18:45:58 2014
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 143F72EC;
 Fri, 29 Aug 2014 18:45:58 +0000 (UTC)
Received: from mail-n.franken.de (drew.ipv6.franken.de
 [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client CN "mail-n.franken.de", Issuer "Thawte DV SSL CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C8C1C15AE;
 Fri, 29 Aug 2014 18:45:57 +0000 (UTC)
Received: from [192.168.1.200] (p508F16A0.dip0.t-ipconnect.de [80.143.22.160])
 (Authenticated sender: macmic)
 by mail-n.franken.de (Postfix) with ESMTP id 1B0FC1C0B4058;
 Fri, 29 Aug 2014 20:45:53 +0200 (CEST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: Problem running make_dtb.sh
From: Michael Tuexen <tuexen@freebsd.org>
In-Reply-To: <1409320716.1150.169.camel@revolution.hippie.lan>
Date: Fri, 29 Aug 2014 20:45:52 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <7D1D98AB-39AE-4C36-BC4C-5D328956CDAC@freebsd.org>
References: <F06A8E2E-EEDE-4767-85EF-2834ECF547D2@freebsd.org>
 <1409320716.1150.169.camel@revolution.hippie.lan>
To: Ian Lepore <ian@FreeBSD.org>
X-Mailer: Apple Mail (2.1878.6)
Cc: "freebsd-arm@freebsd.org" <arm@freebsd.org>
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Aug 2014 18:45:58 -0000

On 29 Aug 2014, at 15:58, Ian Lepore <ian@FreeBSD.org> wrote:

> On Fri, 2014-08-29 at 14:44 +0200, Michael Tuexen wrote:
>> Dear all,
>>=20
>> when trying to build the kernel on a Wandboard the traditional way as =
described in
>> =
https://www.freebsd.org/doc/en/books/developers-handbook/kernelbuild.html#=
kernelbuild-traditional
>> a make results in
>> ...
>> sh ../../../tools/fdt/make_dtb.sh ../../.. wandboard-quad.dts =
/usr/home/tuexen/sys/arm/compile/WANDBOARD-QUAD
>> converting wandboard-quad.dts -> =
/usr/home/tuexen/sys/arm/compile/WANDBOARD-QUAD/wandboard-quad.dtb
>> <built-in>:159:10: fatal error: 'wandboard-quad.dts' file not found
>> #include "wandboard-quad.dts"
>>         ^
>> 1 error generated.
>> Error: <stdin>:1.1-2.1 syntax error
>> FATAL ERROR: Unable to parse input tree
>> *** Error code 1
>>=20
>> Stop.
>>=20
>> The reason is that make_dtb.sh uses $MACHINE which is not set. If I =
set it to arm, the make completes
>> successfully. How is this fixed in the best way?
>>=20
>> Best regards
>> Michael
>=20
> IMO, the best way to fix it would be to update the handbook to say =
that
> the "traditional" way of building a kernel is no longer supported.
> Since that won't fly due to a small but very vocal minority, maybe the
> attached patch would be a good fix.
>=20
> -- Ian
>=20
> Index: sys/tools/fdt/make_dtb.sh
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- sys/tools/fdt/make_dtb.sh	(revision 270064)
> +++ sys/tools/fdt/make_dtb.sh	(working copy)
> @@ -12,6 +12,10 @@ if [ -z "$dts" ]; then
>     exit 1
> fi
>=20
> +if [ -z "${MACHINE}" ]; then
> +    MACHINE=3D$(uname -m)
> +fi
> +
> for d in ${dts}; do
>     dtb=3D${dtb_path}/`basename $d .dts`.dtb
>     echo "converting $d -> $dtb"
That resolves the issue. Will you commit it?

Best regards
Michael