From owner-svn-ports-all@freebsd.org Wed Dec 27 17:20:37 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C98EDEA2571; Wed, 27 Dec 2017 17:20:37 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A61DA6DE16; Wed, 27 Dec 2017 17:20:37 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id F1E9A16251; Wed, 27 Dec 2017 17:20:36 +0000 (UTC) Date: Wed, 27 Dec 2017 17:20:36 +0000 From: Alexey Dokuchaev To: Jason Bacon Cc: Adam Weinberger , yuri@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r456674 - in head/graphics: . libQGLViewer libQGLViewer/files Message-ID: <20171227172036.GA7861@FreeBSD.org> References: <20171224135522.GA1693@FreeBSD.org> <6fa2551a-dee7-9388-07fc-6539800b6c5a@freebsd.org> <20171225112028.GA61880@FreeBSD.org> <0e81e642-9157-d8e3-12f2-af08724accf6@gmail.com> <20171226155201.GA90333@FreeBSD.org> <4105e72a-cdd1-c792-7f69-e00bb22d01cb@gmail.com> <20171227082713.GB51426@FreeBSD.org> <5b2cd5f1-5fcb-35d2-9339-dcf97cd11d3f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b2cd5f1-5fcb-35d2-9339-dcf97cd11d3f@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 17:20:37 -0000 On Wed, Dec 27, 2017 at 10:54:10AM -0600, Jason Bacon wrote: > On 12/27/17 02:27, Alexey Dokuchaev wrote: > > On Tue, Dec 26, 2017 at 02:47:05PM -0600, Jason Bacon wrote: > > ... > >> Are you suggesting that PORTNAME should also be reduced to lowercase > >> to match the directory name? > > > > I'd say most certainly yes, unless I'm overlooking a particular > > edge-case where it could be useful, but I cannot think of right now. > > Do you have some specific port(s) in mind? > > emulators/virtualbox-ose is an example. DISTNAME and the main binary > both contain caps, but the maintainers chose to lowercase both the > portname and directory name. `emulators/virtualbox-ose' is correctly named (both port directory- and the DISTNAME-wise). > math/freemat is a counterexample, where the directory name was > lowercased, but PORTNAME contains caps to match DISTNAME. Correctly placed, but wrong PORTNAME. It should be fixed (should not be too hard; it's unmaintained port anyways). > Mixed case in directory names is a nuisance when trying to use shell > auto-complete, for example. Yes, it is; another good example is `audio/Maaate' (e.g. try to edit the category Makefile :-). > I can't think of a strong reason to favor either lowercase or mixed for We're Unix, lowercase is in our blood: most things, from commands, login names to header files and APIs are lowercased. This naturally applies to port and package names. Add to this all the nuisance with collation, sorting order, shell tab-completion... > PORTNAME, though, since pkg is case-insensitive and we'll always need > to use -i when grepping for PORTNAME anyway, unless all PORTNAMEs are > reduced to lower case. Reducing *all* PORTNAMEs to lowercase would be wrong, and I never had advocated for this; e.g. p5-* and libX* ports are named correctly, as was mentioned earlier. ./danfe