From owner-cvs-src@FreeBSD.ORG Tue Feb 20 18:20:32 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1B88C16AC2E; Tue, 20 Feb 2007 18:20:32 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id B197413C442; Tue, 20 Feb 2007 18:20:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l1KIKQUH086577; Tue, 20 Feb 2007 13:20:28 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Kostik Belousov Date: Tue, 20 Feb 2007 11:24:02 -0500 User-Agent: KMail/1.9.4 References: <200702191057.l1JAvmZW059331@repoman.freebsd.org> <200702191849.54339.jhb@freebsd.org> <20070220144012.GX39168@deviant.kiev.zoral.com.ua> In-Reply-To: <20070220144012.GX39168@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200702201124.03426.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Tue, 20 Feb 2007 13:20:28 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2613/Tue Feb 20 11:39:58 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/i386 db_trace.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2007 18:20:32 -0000 On Tuesday 20 February 2007 09:40, Kostik Belousov wrote: > On Mon, Feb 19, 2007 at 06:49:53PM -0500, John Baldwin wrote: > > On Monday 19 February 2007 05:57, Konstantin Belousov wrote: > > > kib 2007-02-19 10:57:48 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/i386/i386 db_trace.c > > > Log: > > > Unbreak ddb stepping over special frames after the following commit: > > > > amd64 might need the same fix, and kgdb needs to be updated for both as > > well if it hasn't been already. > I doubt it. Register calling conventions for amd64 made the same change > for this architecture to look like > movq %rsp, %rdi > thus not modifying stack frame layout. Could someone with amd64 current box > confirm/deny this ? Ah, ok, had wondered about that. > Kgdb is more involved. I think that some compatibility stuff needed there, > to be able to step over both old and new kind of frames. Yes, it will have to use the nearest __FreeBSD_version by checking the osreldate variable from the core dump. -- John Baldwin