Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Jan 2019 07:05:08 +0000
From:      bugzilla-noreply@freebsd.org
To:        rc@FreeBSD.org
Subject:   [Bug 235185] www/fcgiwrap: environment should be cleaned in /usr/local/etc/rc.d/fcgiwrap
Message-ID:  <bug-235185-20181-lo04L6YXBk@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-235185-20181@https.bugs.freebsd.org/bugzilla/>
References:  <bug-235185-20181@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235185

--- Comment #30 from vas@mpeks.tomsk.su ---
(In reply to Rodney W. Grimes from comment #19)
> If you are calling this exporting of the environment a feature of fcgiwra=
p then us revoking the environment with env -i would be removing an authors=
 inteded feature.

We are already doing that, albeit in an inconsistent manner: we clean the
environment in /usr/sbin/service and not clean when running rc.d scripts
directly). Now that I think of it, I see the major problem being this
inconsistency.

And guys, before you start coding, please remember that login.conf and other
environment variable assignments probably should go _after_ the initial
environment sanitation. So first you cut off whatever is inherited from the
invoker's environment (like it is done in /usr/sbin/service) and then you
assign the necessary variables in the rc.d script already.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-235185-20181-lo04L6YXBk>