From owner-freebsd-ports@FreeBSD.ORG Tue Aug 25 22:50:04 2009 Return-Path: Delivered-To: ports@freebsd.org Received: from straylight.ringlet.net (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with SMTP id A9EC01065694 for ; Tue, 25 Aug 2009 22:50:03 +0000 (UTC) (envelope-from roam@ringlet.net) Received: (qmail 1532 invoked by uid 1000); 25 Aug 2009 22:50:01 -0000 Date: Wed, 26 Aug 2009 01:50:01 +0300 From: Peter Pentchev To: Kevin Oberman Message-ID: <20090825225001.GA1087@straylight.m.ringlet.net> References: <20090825180618.BD0331CC09@ptavv.es.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gBBFr7Ir9EOA20Yy" Content-Disposition: inline In-Reply-To: <20090825180618.BD0331CC09@ptavv.es.net> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: ports@freebsd.org, ahze@freebsd.org Subject: Re: serpentine port forces dependency on muine X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2009 22:50:04 -0000 --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 25, 2009 at 11:06:18AM -0700, Kevin Oberman wrote: > I have been trying to remove all dependencies on the broken muine port > and discovered that an error in the serpentine port Makefile causes > serpentine to always depend on muine. >=20 > The Makefile uses the config option MUINE to indicate whether to build > the muine plugin, but the script then checks "WITH_MUINE" and always > build the muine plugin and creates a dependency on muine. >=20 > I have opened PR ports/138179. >=20 > I patched the Makefile with: > --- sysutils/serpentine/Makefile.orig 2009-08-25 10:45:24.000000000 -0700 > +++ sysutils/serpentine/Makefile 2009-08-25 10:07:00.000000000 -0700 > @@ -29,7 +29,7 @@ > =20 > .include > =20 > -.if (defined(WITH_MUINE) || exists(${LOCALBASE}/bin/muine)) && ${ARCH}= =3D=3D"i386" > +.if (defined(MUINE) || exists(${LOCALBASE}/bin/muine)) && ${ARCH}=3D=3D"= i386" > BUILD_DEPENDS+=3D muine:${PORTSDIR}/audio/muine > RUN_DEPENDS+=3D muine:${PORTSDIR}/audio/muine > PLIST_SUB+=3D MUINE=3D"" Errrr... I strongly doubt that this is the reason for your problems. Actually, this is exactly how the Ports Collection's "options" framework is supposed to work: the OPTIONS variable lists just the names of the options, then bsd.port.mk prompts the user through a dialog (or just uses the options' default values) and sets either WITH_name or WITHOUT_name. The port then checks for WITH_name or WITHOUT_name, just as it does in this case. The option is named "MUINE", but the bsd.port.mk framework will set "WITH_MUINE" if the user wants it, or WITHOUT_MUINE if she doesn't (or building in batch mode, since the option defaults to Off). So the Makefile check is actually correct. I find it a little bit hard to believe that it is exactly this change to the Makefile that helped you get a serpentine build without muine. Could it be that, in the meantime, you had also removed the muine port itself? The Makefile check will be satisfied if the MUINE option is enabled *or* if the "muine" executable is present in /usr/local/bin. This is most probably because the serpentine configure script looks for muine itself and uses it unconditionally if it finds it. So... maybe you just had a /usr/local/bin/muine, and that made the serpentine port always build with it? Because the Makefile check is actually correct as per the ports options framework :/ G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@space.bg roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 The rest of this sentence is written in Thailand, on --gBBFr7Ir9EOA20Yy Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (FreeBSD) iEYEARECAAYFAkqUapkACgkQ7Ri2jRYZRVNiNgCeO8+1ZqY5exCREK+LyoIJJ6NG 4sAAn13ByCdM+VXg+71S+qWnKD2Ght+Y =yt7p -----END PGP SIGNATURE----- --gBBFr7Ir9EOA20Yy--