Date: Tue, 13 Nov 2018 20:07:00 +0100 From: Harry Schmalzbauer <freebsd@omnilan.de> To: Scott Long <scottl@samsco.org> Cc: scsi@freebsd.org, freebsd-stable <freebsd-stable@freebsd.org> Subject: Re: MSI allocation regression, still to be corrected in HEAD and please MFC before release/12.0 gets branched Message-ID: <0a8ea65b-f408-05f1-c45d-31ae5e0eb902@omnilan.de> In-Reply-To: <34515651-9883-4490-A3EE-7206AE973757@samsco.org> References: <201707300653.v6U6rwLN099096@repo.freebsd.org> <597DA578.6030101@omnilan.de> <597F56A8.1060603@omnilan.de> <D18DFAD4-6E93-4AE2-BE15-EFF4D8ABCB2A@samsco.org> <59804C8C.1020003@omnilan.de> <e7d94e6a-89e8-ffa1-40da-7fb67e6bfc2b@omnilan.de> <78611650-D7A4-4B1D-A254-DB058E1AC1C6@samsco.org> <d99e383d-b09a-f3bd-f1e2-a6a808016347@omnilan.de> <A2AECF9F-2BB1-4FC0-8330-658336A3A4F0@samsco.org> <6e1e5f9f-4ece-dc9d-b059-08d52c9e6965@omnilan.de> <042090da-f73f-ce80-517c-0b1729d3d6e1@omnilan.de> <05D94EC4-D797-4246-96B5-6DC1494E7EA9@samsco.org> <d28eee74-99dc-296b-fd19-ea2c1adec0ee@omnilan.de> <34515651-9883-4490-A3EE-7206AE973757@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 13.11.2018 um 19:45 schrieb Scott Long: > > >> On Nov 13, 2018, at 11:11 AM, Harry Schmalzbauer <freebsd@omnilan.de> wrote: >> >> Am 13.11.2018 um 19:02 schrieb Scott Long: >>>> On Nov 12, 2018, at 10:03 AM, Harry Schmalzbauer <freebsd@omnilan.de> wrote: >>>> >>>> Am 11.06.2018 um 20:28 schrieb Harry Schmalzbauer: >>>>> Am 05.06.2018 um 19:54 schrieb Scott Long: >>>>> … >>>>>>>>> Late in the 11.2 phase, I identified this commit as a regression for MSI (non-x) alloctaion. … >> >> thanks a lot, in fact I'm not surprised that you come up with a better solution than that quick fix :-) >> Had hoped someone else would do an intermediate commit to get it into 12.0 in time, so you won't feel any time pressure - good job needs the time it needs, as long as the right person is doing the job. >> >> Unfortunately I don't have a non-productive setup where I could test before release/12.0 will be branched – might be subject to change... > > 12.0 has completely different code from 11.x, and from my review of it last night it should be fine. If you have evidence that what’s currently in 12 is not working, please let me know ASAP. Sorry for the confusion, I missed that. I just verified that I do apply the patch (without errors) to local stable/12 source tree for local releases... That's probably a mistake. I can't remember if I ever checked whether stable/12 (for sure not stable/12, but -current back then) MSI fallback allocation does work without the patch or not. Like metioned, I don't have a non-productive machine of that kind for testing, but it's superfluous anyways if you know that code paths differ in that part. Please ignore my 12.0 referings, sorry. -harry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0a8ea65b-f408-05f1-c45d-31ae5e0eb902>