From owner-svn-src-all@FreeBSD.ORG Sat Dec 20 11:55:19 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 96070106564A; Sat, 20 Dec 2008 11:55:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 385388FC08; Sat, 20 Dec 2008 11:55:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LE0QQ-000Owm-3A; Sat, 20 Dec 2008 13:55:18 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id mBKBt6gl020658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 20 Dec 2008 13:55:06 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id mBKBt5h1052910; Sat, 20 Dec 2008 13:55:05 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id mBKBt5Ag052909; Sat, 20 Dec 2008 13:55:05 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 20 Dec 2008 13:55:05 +0200 From: Kostik Belousov To: Maxim Sobolev Message-ID: <20081220115505.GZ2038@deviant.kiev.zoral.com.ua> References: <200812192020.mBJKKEIo081792@svn.freebsd.org> <494C097C.1020604@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OM3frZe47dgZ1O53" Content-Disposition: inline In-Reply-To: <494C097C.1020604@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LE0QQ-000Owm-3A 64e6314b02f53f1f1aba14566fcfda6b X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, "David E. O'Brien" Subject: Re: svn: head/usr.sbin/burncd X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Dec 2008 11:55:19 -0000 --OM3frZe47dgZ1O53 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 19, 2008 at 12:52:12PM -0800, Maxim Sobolev wrote: > Should not it be better to implement this on the kernel side when the=20 > device is closed abruptly? The state that is kept is not accumulated on any particular filedescriptor, it is associated with the physical state of the device. Therefore, I think that kernel shall not be charged with cleanup, and userspace calls should deal with resetting device back to the pristine state. >=20 > David E. O'Brien wrote: > >Author: obrien > >Date: Fri Dec 19 20:20:14 2008 > >New Revision: 186337 > >URL: http://svn.freebsd.org/changeset/base/186337 > > > >Log: > > burncd(8) doesn't handle signals and interrupting burncd during=20 > > operation. > > For example, ^C (SIGINT) may leave the drive spinning and locked. > > This may also happen if you try to write a too-large image to a disc > > and burncd(8) exits with an I/O error. > > =20 > > Add signal handling by doing a CDRIOCFLUSH ioctl to attempt to leave > > burner in a sane state when burning is interrupted with SIGHUP, SIGINT, > > SIGTERM, or in case an I/O error occurs during write. > > Note, that blanking will still continue after interrupt but it seems to > > finish correctly even after burncd(8) has quit. >=20 > -Maxim --OM3frZe47dgZ1O53 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAklM3RkACgkQC3+MBN1Mb4gP9QCdEf4Cx27uFgNZr1+2D4YFj3H0 FSMAn1dbiKVrEcCuBUAkmjmFJhygizAa =hwah -----END PGP SIGNATURE----- --OM3frZe47dgZ1O53--