Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Dec 2008 22:05:46 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r186059 - head/sys/netgraph
Message-ID:  <200812132205.mBDM5kPZ041007@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Sat Dec 13 22:05:46 2008
New Revision: 186059
URL: http://svn.freebsd.org/changeset/base/186059

Log:
  Remove node shutdown on tty close. This could be easily done by user-level
  while it's present implementation with ng_rmnode_flags() is at least
  incorrect.

Modified:
  head/sys/netgraph/ng_tty.c

Modified: head/sys/netgraph/ng_tty.c
==============================================================================
--- head/sys/netgraph/ng_tty.c	Sat Dec 13 22:04:52 2008	(r186058)
+++ head/sys/netgraph/ng_tty.c	Sat Dec 13 22:05:46 2008	(r186059)
@@ -114,7 +114,6 @@ static th_getc_poll_t		ngt_getc_poll;
 static th_rint_t		ngt_rint;
 static th_rint_bypass_t		ngt_rint_bypass;
 static th_rint_poll_t		ngt_rint_poll;
-static th_close_t		ngt_close;
 
 static struct ttyhook ngt_hook = {
 	.th_getc_inject = ngt_getc_inject,
@@ -122,7 +121,6 @@ static struct ttyhook ngt_hook = {
 	.th_rint = ngt_rint,
 	.th_rint_bypass = ngt_rint_bypass,
 	.th_rint_poll = ngt_rint_poll,
-	.th_close = ngt_close,
 };
 
 /* Netgraph node type descriptor */
@@ -515,12 +513,3 @@ ngt_rint_poll(struct tty *tp)
 	return (1);
 }
 
-static void
-ngt_close(struct tty *tp)
-{
-	sc_p sc = ttyhook_softc(tp);
-
-	/* Must be queued to drop the tty lock */
-	ng_rmnode_flags(sc->node, NG_QUEUE);
-}
-



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812132205.mBDM5kPZ041007>