Date: Mon, 13 Sep 2010 18:26:32 +0000 (UTC) From: Weongyo Jeong <weongyo@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r212569 - user/weongyo/usb/sys/dev/usb/controller Message-ID: <201009131826.o8DIQWrL023326@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: weongyo Date: Mon Sep 13 18:26:32 2010 New Revision: 212569 URL: http://svn.freebsd.org/changeset/base/212569 Log: Don't need to hold Giant again at attach because it's already hold from the bus driver. Instead of holding it adds a assert. Modified: user/weongyo/usb/sys/dev/usb/controller/usb_controller.c Modified: user/weongyo/usb/sys/dev/usb/controller/usb_controller.c ============================================================================== --- user/weongyo/usb/sys/dev/usb/controller/usb_controller.c Mon Sep 13 17:53:43 2010 (r212568) +++ user/weongyo/usb/sys/dev/usb/controller/usb_controller.c Mon Sep 13 18:26:32 2010 (r212569) @@ -394,10 +394,9 @@ usb_attach_sub(device_t dev, struct usb_ { const char *pname = device_get_nameunit(dev); - mtx_lock(&Giant); + GIANT_REQUIRED; if (usb_devclass_ptr == NULL) usb_devclass_ptr = devclass_find("usbus"); - mtx_unlock(&Giant); /* Initialise USB explore taskqueue and tasks */ bus->explore_tq = taskqueue_create("usb_explore_taskq", M_WAITOK,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009131826.o8DIQWrL023326>