From owner-freebsd-ports Fri Aug 23 8:10:22 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3EDC837B400 for ; Fri, 23 Aug 2002 08:10:09 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3A5C143EA3 for ; Fri, 23 Aug 2002 08:10:03 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g7NFA3JU077923 for ; Fri, 23 Aug 2002 08:10:03 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g7NFA3dc077922; Fri, 23 Aug 2002 08:10:03 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EDAE37B400 for ; Fri, 23 Aug 2002 08:08:05 -0700 (PDT) Received: from bigboy.spc.org (dolly.good1.com [195.206.69.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45C1343E4A for ; Fri, 23 Aug 2002 08:08:04 -0700 (PDT) (envelope-from bms@spc.org) Message-Id: <20020823150747.A321E9638@triage.dollah.com> Date: Fri, 23 Aug 2002 16:07:47 +0100 (BST) From: Bruce M Simpson Reply-To: Bruce M Simpson To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/41945: bsd.port.mk: does not run ACLOCAL Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 41945 >Category: ports >Synopsis: bsd.port.mk: does not run ACLOCAL >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Aug 23 08:10:02 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Bruce M Simpson >Release: FreeBSD 4.6-STABLE i386 >Organization: >Environment: System: FreeBSD triage.dollah.com 4.6-STABLE FreeBSD 4.6-STABLE #0: Tue Aug 20 13:00:06 BST 2002 root@triage.dollah.com:/usr/src/sys/compile/TRIAGE i386 >Description: Some ports require the relevant ACLOCAL script to be run in order to pick up all included automake definitions. The ports affected are mainly those using a later version of GNU automake than 1.4. >How-To-Repeat: >Fix: A patch is enclosed which will allow port maintainers to use a new Makefile macro, USE_ACLOCAL, to specify that ACLOCAL must be run as part of the do-configure target. Not running ACLOCAL causes some ports to fail during do-configure target, or for repetitive and ugly kludges to be used in their Makefiles. The patch is offered in the spirit of 'prevention better than cure'. --- portmk.patch begins here --- --- bsd.port.mk.orig Fri Aug 23 15:46:18 2002 +++ bsd.port.mk Fri Aug 23 16:03:31 2002 @@ -154,6 +154,9 @@ # and ACLOCAL{,_DIR} variables. # Implies USE_AUTOMAKE. If set with # unknown value, defaults to 14. +# +# USE_ACLOCAL - Says that the port needs ACLOCAL to be run. +# # AUTOMAKE - Set to path of GNU automake if not in $PATH (default: # according to USE_AUTOMAKE_VER value) # AUTOMAKE_ARGS - Pass these args to ${AUTOMAKE} if ${USE_AUTOMAKE_VER} is set. @@ -2241,6 +2244,10 @@ .if !target(do-configure) do-configure: +.if defined(USE_ACLOCAL) + @(cd ${CONFIGURE_WRKSRC} && ${SETENV} ${AUTOMAKE_ENV} ${ACLOCAL} \ + --acdir=${ACLOCAL_DIR}) +.endif .if defined(USE_AUTOMAKE) @(cd ${CONFIGURE_WRKSRC} && ${SETENV} ${AUTOMAKE_ENV} ${AUTOMAKE} \ ${AUTOMAKE_ARGS}) --- portmk.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message