Date: Fri, 16 Feb 2007 07:33:12 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/hpfs hpfs_vfsops.c hpfs_vnops.c src/sys/fs/msdosfs msdosfs_vfsops.c msdosfs_vnops.c src/sys/fs/ntfs ntfs_vfsops.c ntfs_vnops.c src/sys/fs/nullfs null_vfsops.c null_vnops.c src/sys/fs/udf udf.h udf_vfsops.c ... Message-ID: <20070216073206.C83539@fledge.watson.org> In-Reply-To: <200702152208.l1FM8aY7002188@repoman.freebsd.org> References: <200702152208.l1FM8aY7002188@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 15 Feb 2007, Pawel Jakub Dawidek wrote: > Move vnode-to-file-handle translation from vfs_vptofh to vop_vptofh method. > This way we may support multiple structures in v_data vnode field within > one file system without using black magic. > > Vnode-to-file-handle should be VOP in the first place, but was made VFS > operation to keep interface as compatible as possible with SUN's VFS. > BTW. Now Solaris also implements vnode-to-file-handle as VOP operation. > > VFS_VPTOFH() was left for API backward compatibility, but is marked for > removal before 8.0-RELEASE. > > Approved by: mckusick > Discussed with: many (on IRC) > Tested with: ufs, msdosfs, cd9660, nullfs and zfs Do you think API backward compatibility is actually required in 7.x? It looks like you've updated all the file systems, in which case the temptation would be to drop it as we already have other VFS changes in 7.x from 6.x. Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070216073206.C83539>