Date: Mon, 12 Jun 2006 10:18:58 -0700 From: Nate Lawson <nate@root.org> To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c Message-ID: <448DA202.5020009@root.org> In-Reply-To: <867j3m2ujs.fsf@xps.des.no> References: <200606112031.k5BKVf8u056762@repoman.freebsd.org> <867j3m2ujs.fsf@xps.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smørgrav wrote: > Nate Lawson <njl@FreeBSD.org> writes: >> Log: >> By default, don't disable ACPI during reboot. This appears to hang some >> systems. Introduce a new sysctl "hw.acpi.disable_on_reboot" that allows >> users to re-enable the old behavior in case it's needed for some systems. >> We never disable in the power-off path. > > Seems like you forgot something: > > cc -O2 -pipe -march=pentium4 -DACPI_USE_LOCAL_CACHE -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I- -I/usr/src/sys/modules/acpi/acpi/../../../contrib/dev/acpica -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/xps/opt_global.h -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -g -I/usr/obj/usr/src/sys/xps -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -fformat-extensions -std=c99 -c /usr/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi.c > /usr/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi.c: In function `acpi_attach': > /usr/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi.c:525: error: structure has no member named `acpi_do_disable' > /usr/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi.c: In function `acpi_shutdown_final': > /usr/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi.c:1672: error: structure has no member named `acpi_do_disable' > *** Error code 1 > > DES Thanks, wasn't in the original commit but was in the MFC. pointy hat for today -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?448DA202.5020009>