Date: Thu, 12 Nov 2015 08:07:34 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Jung-uk Kim <jkim@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r401297 - head/databases/firebird25-server Message-ID: <20151112070734.GP10134@ivaldir.etoilebsd.net> In-Reply-To: <20151112020446.GA43902@FreeBSD.org> References: <201511112104.tABL4b3j045859@repo.freebsd.org> <20151111221237.GO10134@ivaldir.etoilebsd.net> <5643C272.5080309@FreeBSD.org> <20151112020446.GA43902@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--tjOMJDssiV0CZSJH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Nov 12, 2015 at 02:04:46AM +0000, Alexey Dokuchaev wrote:
> On Wed, Nov 11, 2015 at 05:34:26PM -0500, Jung-uk Kim wrote:
> > [...]
> > Yes, I understand all of the above issues. However, what I dislike is
> > the fact that USES=3Dlibedit implies USES=3Dlocalbase. Therefore, it
> > unconditionally spams CFLAGS, CPPFLAGS, CXXFLAGS, and LDFLAGS.
>=20
> Hmm, looks like this ".include "${USESDIR}/localbase.mk" line should not
> be needed: `devel/libedit' installs libdata/pkgconfig/libedit.pc and its
> consumers should use pkgconf(1) instead of expecting headers and libraries
> at some default paths.
>=20
> The problem I guess is that no one wants to patch consumer ports to use
> pkgconf(1) for libedit. :-(
>=20
Except that pkg-config would also add to cflags -I... which would be worse =
than
-isystem ...
So what you do propose won't help at all.
Best regards,
bapt
--tjOMJDssiV0CZSJH
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlZEOrYACgkQ8kTtMUmk6EwinQCdEP4N9OsTBYvs04Grt9GAVX0O
ETsAniTz7t/Ud8Ff2byIcIM/EuPVv2Qm
=YF9S
-----END PGP SIGNATURE-----
--tjOMJDssiV0CZSJH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151112070734.GP10134>