From owner-cvs-all@FreeBSD.ORG Sat Jul 14 21:13:44 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DCE5F16A405 for ; Sat, 14 Jul 2007 21:13:43 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.237]) by mx1.freebsd.org (Postfix) with ESMTP id 7D62013C4A7 for ; Sat, 14 Jul 2007 21:13:43 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: by nz-out-0506.google.com with SMTP id l8so592759nzf for ; Sat, 14 Jul 2007 14:13:42 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=hrzUQRgwV2dOIR7tMgQAcvvUSAiU/UFXapKKcOQAh3mQmggjzh7yH8KC7X3ScXug056YQfaJvbIQMvHepZwY87PzmG6BAG4klQMDzYkQuVsZXMK5qRL7l/YcdlCZmKa3VQrDAllTKCXQXCf5lRGQHO+FYEug5dXb0BE86CM7mQM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=NDjg+D5yNc//FmdKku46Oce82yDXZ0L9jLE4bxhwTIjXv61lLhK5r90el0jjp58VNh5oUClI3AZunuWYD14KUZEt4uzSjQ160R9sNq1p3vhMbaDHtBjRgcxeHXXWSevQIKrYK252hZ6rNsZOAhS3trg8KiDVK2wOzYyHUWcK6hA= Received: by 10.142.108.14 with SMTP id g14mr217805wfc.1184447622206; Sat, 14 Jul 2007 14:13:42 -0700 (PDT) Received: by 10.143.14.5 with HTTP; Sat, 14 Jul 2007 14:13:42 -0700 (PDT) Message-ID: <47d0403c0707141413y7086e177hec3bbba1d2e14714@mail.gmail.com> Date: Sat, 14 Jul 2007 16:13:42 -0500 From: "Ben Kaduk" To: "Bruce Evans" In-Reply-To: <20070714143935.W6715@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200707121717.l6CHHl2w076935@repoman.freebsd.org> <47d0403c0707131800h571bfb97ydf12f313b7fd68a1@mail.gmail.com> <20070714143935.W6715@besplex.bde.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Bruce Evans , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/fs/msdosfs msdosfs_vfsops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2007 21:13:44 -0000 On 7/14/07, Bruce Evans wrote: > On Fri, 13 Jul 2007, Ben Kaduk wrote: > > > I recently got a patch committed to the installation chapter of the > > handbook, which included two occasions of clarifying ``MS-DOS > > filesystem'' as ``FAT16 or FAT32'' [1,2 for present incarnation]. I > > am too young to remember the existence of FAT12, so I'll have to defer > > to others as to whether the handbook should mention FAT12 in the same > > breath as FAT16 and FAT32. What do you think? > > I think FAT* is newspeak :-). The file system is named msdosfs, not FAT. > Anyway, the number of bits per FAT entry is of no interest in most cases, > so it shouldn't be emphasized. newfs_msdos will choose the best number, > or if you tell it, any number that can work. newfs_msdos(8) says > "construct a new MS-DOS (FAT) file system ... creates a FAT12, FAT16 or > FAT32 file system". It doesn't say anything about how newfs_msdos chooses > the best FAT size or other important parameters. newfs_msdos still hasn't > caught up with the renaming of file systems from foo to foofs. > > > [1] > > http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/install-pre.html > > [2] > > http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/install-trouble.html > > A quick reading showed some bugs in [2]: > - just after "FAT16 and FAT32", it says "The utility most common usage is > # mount_msdosfs /dev/ad0s1 /mnt". It should say something like "This > utility's most common usage is indirectly via a line in /etc/fstab or > mount -t msdosfs. [Example line in fstab, and the above command line > with direct use of mount_msdosfs fixed.] This [section of?] the > handbook is too small to describe utilities in not most common usage > like newfs_msdos." > > - a little later, it says It says "Extended MS-DOS file systems are usually > mapped after FreeBSD partitions ... with the extended MS-DOS partition > located on /dev/ad0s3", but there is no such thing as an extended MS-DOS > file system. It should say something like "MS-DOS logical drives are > usually mapped after primary partitions ... with the first logical drive > being /dev/ad0s3" and possibly add some details ("partition" here means > an MS-DOS primary partition; MS-DOS extended partitions aren't mapped; > MS-DOS logical drives correspond to FreeBSD slices, except for primary > partitions the partitions correspond to slices; check that in MS-DOS > speak, primary partitions aren't described as logical drives; logical > drives may or may not contain a file system, but in this example > /dev/ad0s3 has an MS-DOS file system, and I didn't reword things enough > to describe this). > > Bruce > Thanks, Bruce. I will package your corrections into a patch and send it to the folks at -doc@ . I suppose I _should_ take this as a lesson to not mix content changes with grammar/punctuation changes (I am trying to sweep the handbook for such), but it will probably be too hard for me to ignore some of them. -Ben Kaduk