Date: Fri, 17 Apr 2015 07:54:01 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-arch@freebsd.org, peter@freebsd.org, Konstantin Belousov <kostikbel@gmail.com> Subject: Re: Removal of the 6.x kernel compat code from libc Message-ID: <F78F3246-4479-4FFC-9881-E63925F95941@bsdimp.com> In-Reply-To: <3447437.tTGu6eNHtf@ralph.baldwin.cx> References: <20150417075942.GI2390@kib.kiev.ua> <3447437.tTGu6eNHtf@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_B6C74F8F-736C-473D-ADC9-A0E20AA9535B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 17, 2015, at 7:29 AM, John Baldwin <jhb@freebsd.org> wrote: >=20 > On Friday, April 17, 2015 10:59:42 AM Konstantin Belousov wrote: >> Our libc changes in sync with the kernel, but switching of libc to = use >> new interfaces means that upgrade of the userspace becomes the flag = day. >> People usually add backward-compatible shims for libc to use older >> interfaces on old kernels. >>=20 >> There is no reason to keep the compat shims after many years of the >> transition. Patch below purges the compat code for pre-r171219, = which >> added pad-less versions of syscalls taking off_t, and for r177911, = which >> handles the struct flock/oflock transition. This is 6.x/7.x compat, >> we absolutely not support running HEAD libc on such old kernels. >=20 > I think this is fine. I do too. Please look at removing MK_COMPAT_SYSCALLS from the build too, since it was the only knob that controlled these. I don=E2=80=99t see that in = your patch (though it would be easier for me to comment on in phabricator). Also, in lib/libc/sys/fcnt.c: + * Copyright (c) 2014, 2015 The FreeBSD Foundation. Should be 2014-2015 Warner --Apple-Mail=_B6C74F8F-736C-473D-ADC9-A0E20AA9535B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVMRB5AAoJEGwc0Sh9sBEAJtMQALwot43hq+keyxlp3PAxUyXJ 0e7SqAUAyli/3AJ5xbXPkXu8js8BQjpIwI04KbXUsDvd7h8Mahv5+e9yK/xJz11T 68BR6xBJLXbiPVgNoCrNIChe/JaXqnhsllfW83VUSpoZi45aQnjmFDp4v9PBPO8c qjq/ioRQ8TH++37CXmxBCumaKNtUP1y3iqsJLGnifyp/STWpg43gbkcbIUmclZMd mzjN8uNxVPP9LxvxCdVpxPISDKfcT8aiKtv30K2CZ92IE1Me7u+yVgssjwZ2X25U ij2jVX3nHsHr9VseW+EMEhor51uD+SlsJxk8bJNRwxyo0UHcboc1AXaIofkcwuJY ZkTTZEHxM/T+/EgQUGOcWaGHZs9qbmumIY++rl2hpHqmCT4vhU+qBFbVAIjIxTaG wH+Vsr/YQCRqJao4k64yTcQo3sAHOzoJ52Wffe7XR0TXQ/CgZok/iubDacwkSPoO uobgDLxNbiGFkd7vT2Hsqk7oaSA6XmToHOm8+GL8aVxWKPs0iYfDeVldVxTr1tOI LEugpCFR6MmIIqywSXoXgsMuRj3uysRLiCME4weSh8FYRanz1v5fwOcG937TZT4R bU1IHL+Q8MOaD4ZrE7PTJ3ScrhSnVmxeNzCQY49FWIRuMnDf5D0ne1j6ObItApNU jH2QHstyMpn8O/yDD3ue =t+KZ -----END PGP SIGNATURE----- --Apple-Mail=_B6C74F8F-736C-473D-ADC9-A0E20AA9535B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F78F3246-4479-4FFC-9881-E63925F95941>