Date: Tue, 18 Sep 2001 14:32:57 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Maxim Sobolev <sobomax@FreeBSD.ORG> Cc: chris@calldei.com, brent@rcfile.org, current@FreeBSD.ORG, hackers@FreeBSD.ORG, marcel@FreeBSD.ORG Subject: Re: Junior Kernel Hacker task: improve vnode->v_tag Message-ID: <25282.1000816377@critter> In-Reply-To: Your message of "Tue, 18 Sep 2001 15:09:33 %2B0300." <3BA7397D.A82C213@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <3BA7397D.A82C213@FreeBSD.org>, Maxim Sobolev writes: >> How do you figure? The contents if `f_fstypename' must match >> a configured file system exactly, so it could _not_ be anything. >> To quote sys/kern/vfs_syscalls.c:mount(): > >Oh, yes, you are correct obviously (don't know what I was thinking about). In this >case, it looks like v_tag is redundant, because f_fstypename could be used instead >in a few places where v_tag is abused (the same applies to the statfs.f_type >because essentually it is the same thing as v_tag). Poul, what do you think about >it? In the meantime, I found another place in the kernel where VT_* macros are >[ab]used - it is Linuxlator, attached please find patches to fix it - please >review. Sounds like a plan, and a quick eyeball of the patch shows no trouble. Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25282.1000816377>