From owner-p4-projects@FreeBSD.ORG Wed Jan 3 20:06:14 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id B13F016A47C; Wed, 3 Jan 2007 20:06:14 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0FE6816A412; Wed, 3 Jan 2007 20:06:14 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 4CCE113C4BB; Wed, 3 Jan 2007 20:06:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l03K64Sm022420; Wed, 3 Jan 2007 15:06:05 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Divacky Roman Date: Wed, 3 Jan 2007 14:59:19 -0500 User-Agent: KMail/1.9.1 References: <200612312353.kBVNrYYY007010@repoman.freebsd.org> <200701021129.54537.jhb@freebsd.org> <20070103123256.GA76983@stud.fit.vutbr.cz> In-Reply-To: <20070103123256.GA76983@stud.fit.vutbr.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701031459.20116.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 03 Jan 2007 15:06:05 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2411/Wed Jan 3 13:04:33 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Roman Divacky , Perforce Change Reviews Subject: Re: PERFORCE change 112379 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2007 20:06:15 -0000 On Wednesday 03 January 2007 07:32, Divacky Roman wrote: > On Tue, Jan 02, 2007 at 11:29:54AM -0500, John Baldwin wrote: > > On Sunday 31 December 2006 18:53, Roman Divacky wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=112379 > > > > > > Change 112379 by rdivacky@rdivacky_witten on 2006/12/31 23:53:30 > > > > > > Implement SETALL/GETALL IPC primitives. This fixes some LTP testcases. > > > > Are you sure it's actually working? I thought Linux semid structure was a > > different size, and GETALL and SETALL try to copyin and copyout data from > > userland without doing any conversions. > > I only tested with the LTP tests and it fixed all cases there. > > the [SG]ETALL copies in/out u_char * nsems which looks quite OS independant. > > someone reported that some program doesnt work because of missing SETALL/GETALL > I think that if the one reportes that this patch fixes it we can consider it ok. > (because we have 2 positive reports and 0 negative) > > opinion? Actually, it copies out an array of shorts so I do think it is ok and doesn't need any conversions. -- John Baldwin