From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Oct 31 09:20:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D54E292A for ; Thu, 31 Oct 2013 09:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B5CDE2C3B for ; Thu, 31 Oct 2013 09:20:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9V9K1wF095746 for ; Thu, 31 Oct 2013 09:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9V9K1nf095745; Thu, 31 Oct 2013 09:20:01 GMT (envelope-from gnats) Resent-Date: Thu, 31 Oct 2013 09:20:01 GMT Resent-Message-Id: <201310310920.r9V9K1nf095745@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kimmo Paasiala Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C19698F7 for ; Thu, 31 Oct 2013 09:17:48 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9393B2C1F for ; Thu, 31 Oct 2013 09:17:48 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r9V9HmGk089917 for ; Thu, 31 Oct 2013 09:17:48 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r9V9HmjA089915; Thu, 31 Oct 2013 09:17:48 GMT (envelope-from nobody) Message-Id: <201310310917.r9V9HmjA089915@oldred.freebsd.org> Date: Thu, 31 Oct 2013 09:17:48 GMT From: Kimmo Paasiala To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/183518: sysutils/kiconvtool installs an rc(8) script that references the stage directory instead of PREFIX X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Oct 2013 09:20:02 -0000 >Number: 183518 >Category: ports >Synopsis: sysutils/kiconvtool installs an rc(8) script that references the stage directory instead of PREFIX >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Oct 31 09:20:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Kimmo Paasiala >Release: FreeBSD 10.0-BETA2 stable/10 >Organization: >Environment: FreeBSD freebsd10.rdnzl.info 10.0-BETA2 FreeBSD 10.0-BETA2 #0 r257267: Mon Oct 28 22:42:23 EET 2013 kimmo@freebsd10.rdnzl.info:/usr/obj/usr/src/sys/GENERIC i386 >Description: sysutils/kiconvtool install a kiconv.sh rc(8) script that incorrectly uses the stage directory path to the kiconvtool binary instead of the correct ${PREFIX}/sbin/ path. >How-To-Repeat: Install sysutils/kiconvtool and inspect the "command" variable in the ${PREFIX}/etc/rc.d/kiconv.sh script, it is set to the ${STAGEDIR}${PREFIX}/sbin instead of the correct ${PREFIX}/sbin. >Fix: Apply the attached patch that removes the incorrect PREFIX assignment from the port Makefile and adds support for DESTDIR to the actual Makefile of the software. Patch attached with submission follows: Index: Makefile =================================================================== --- Makefile (revision 332203) +++ Makefile (working copy) @@ -12,8 +12,6 @@ USES= iconv # used by libkiconv, actually -MAKE_ARGS= PREFIX="${STAGEDIR}${PREFIX}" - PLIST_FILES= sbin/${PORTNAME} etc/rc.d/kiconv \ man/man8/${PORTNAME}.8.gz Index: files/patch-Makefile =================================================================== --- files/patch-Makefile (revision 0) +++ files/patch-Makefile (working copy) @@ -0,0 +1,17 @@ +--- Makefile 2011-10-01 00:25:12.000000000 +0300 ++++ Makefile.new 2013-10-31 10:47:12.000000000 +0200 +@@ -11,10 +11,10 @@ + all: kiconvtool kiconv.sh + + install: kiconvtool kiconv.sh +- mkdir -p ${PREFIX}/sbin/ ${PREFIX}/etc/rc.d/ ${PREFIX}/man/man8/ +- ${BSD_INSTALL_PROGRAM} kiconvtool ${PREFIX}/sbin/ +- ${BSD_INSTALL_SCRIPT} kiconv.sh ${PREFIX}/etc/rc.d/kiconv +- ${BSD_INSTALL_MAN} kiconvtool.8 ${PREFIX}/man/man8/ ++ mkdir -p ${DESTDIR}${PREFIX}/sbin/ ${DESTDIR}${PREFIX}/etc/rc.d/ ${DESTDIR}${PREFIX}/man/man8/ ++ ${BSD_INSTALL_PROGRAM} kiconvtool ${DESTDIR}${PREFIX}/sbin/ ++ ${BSD_INSTALL_SCRIPT} kiconv.sh ${DESTDIR}${PREFIX}/etc/rc.d/kiconv ++ ${BSD_INSTALL_MAN} kiconvtool.8 ${DESTDIR}${PREFIX}/man/man8/ + + kiconvtool: kiconvtool.c + ${CC} ${CFLAGS} $> ${LIBS} -o $@ >Release-Note: >Audit-Trail: >Unformatted: