From owner-p4-projects@FreeBSD.ORG  Mon Apr 24 12:41:09 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D95B916A405; Mon, 24 Apr 2006 12:41:08 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 735DC16A401;
	Mon, 24 Apr 2006 12:41:08 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B20A443D48;
	Mon, 24 Apr 2006 12:41:07 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k3OCf5R0052454;
	Mon, 24 Apr 2006 08:41:06 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: John Birrell <jb@freebsd.org>
Date: Mon, 24 Apr 2006 08:29:33 -0400
User-Agent: KMail/1.8.3
References: <200604240353.k3O3rQ9E010703@repoman.freebsd.org>
In-Reply-To: <200604240353.k3O3rQ9E010703@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200604240829.34562.jhb@freebsd.org>
X-Virus-Scanned: ClamAV 0.87.1/1423/Mon Apr 24 04:24:11 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.1 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 95987 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Apr 2006 12:41:09 -0000

On Sunday 23 April 2006 11:53 pm, John Birrell wrote:
> http://perforce.freebsd.org/chv.cgi?CH=3D95987
>
> Change 95987 by jb@jb_freebsd2 on 2006/04/24 03:52:59
>
> 	Just allocate buffer memory for the maximum number of cpus.
>
> Affected files ...
>
> .. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_buffer.c#3 edit
>
> Differences ...
>
> =3D=3D=3D=3D //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_buffe=
r.c#3
> (text+ko) =3D=3D=3D=3D
>
> @@ -69,8 +69,7 @@
>  dtrace_buffer_alloc(dtrace_buffer_t *bufs, size_t size, int flags,
>      processorid_t cpu)
>  {
> -printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__LINE__);
> -#ifdef DOODAD
> +#if defined(sun)
>  	cpu_t *cp;
>  	dtrace_buffer_t *buf;
>
> @@ -142,9 +141,51 @@
>  		buf->dtb_xamot =3D NULL;
>  		buf->dtb_size =3D 0;
>  	} while ((cp =3D cp->cpu_next) !=3D cpu_list);
> -#endif
>
>  	return (ENOMEM);
> +#else
> +	dtrace_buffer_t *buf;
> +	int i;
> +
> +	ASSERT(MUTEX_HELD(&dtrace_lock));
> +	for (i =3D 0; i < mp_ncpus; i++) {

Use mp_maxid rather than mp_ncpus.  CPU ID's in FreeBSD are allowed to be
sparse, but will be in the range 0 .. mp_maxid.

=2D-=20
John Baldwin <jhb@FreeBSD.org> =A0<>< =A0http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve" =A0=3D =A0http://www.FreeBSD.org