Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 11 Jun 2010 14:53:06 -0700
From:      "David E. Thiel" <lx@redundancy.redundancy.org>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, Kelly Hays <kelly.hays@jkhfamily.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/net-im/prosody Makefile ports/net-im/prosody/files prosody.in
Message-ID:  <20100611215306.GI2603@redundancy.redundancy.org>
In-Reply-To: <4C129CB0.8000103@FreeBSD.org>
References:  <201006111649.o5BGn8Wh043693@repoman.freebsd.org> <4C129CB0.8000103@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 11, 2010 at 01:29:36PM -0700, Doug Barton wrote:
> There is a problem with the change here in that the literal /usr/local 
> should be replaced with %%PREFIX%%. However the whole script needs some 
> work. 

Thanks Doug, I should have caught that.

> 4. Simplify the status and stop methods down to one function that takes 
> an argument.

This works mostly well, but I notice that the "restart" command
doesn't work, and was going to add a restart_cmd telling it to issue a
prosodyctl stop followed by prosodyctl start. I kind of think it would
look cleaner to have start_cmd, stop_cmd and restart_cmd rather than
prosody_cmd and restart_cmd. Thoughts?

Thanks,
David



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100611215306.GI2603>