From owner-svn-src-all@freebsd.org Sat Nov 7 16:29:18 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54DEEA2864D for ; Sat, 7 Nov 2015 16:29:18 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DD86E1D43 for ; Sat, 7 Nov 2015 16:29:17 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wmdw130 with SMTP id w130so2276310wmd.0 for ; Sat, 07 Nov 2015 08:29:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=5mxEe8wsSfcXbWP6wgNlK4nLAq43d6dsLTo1eDSl+SA=; b=daqhsD4wSDXrqV17/wGn6Zmab+AM4hpj/w0UDy+Uprv9pSEYNyzJcIYop7oPqSnO9A ocpNyYSAIsF6KbhEl2j07R997SlMrW2m3N982i3WnyOo8JAryj+sRy8/mgUK2LoTpwnt He/cj3Uf9HpsHQW8rzS0RYqCrJPEaqFf+eTinxlXTDB1/bsVFbuUj6TwDepBxFE0B2gn RwRZKKmVwc8XPpgJrkaF+pqluUjHl66G433WSd2h51pLOUHZY0TcWHV5yjdb7kwhphi9 H8G7OCm610T4/bseL9cTVI459EfNJFa6vC5DDD1f+bZ7rj90Aa5yRPj12nE9thC1O45L A9Mg== X-Received: by 10.28.88.135 with SMTP id m129mr17479325wmb.67.1446913756470; Sat, 07 Nov 2015 08:29:16 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id d10sm5812018wje.14.2015.11.07.08.29.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Nov 2015 08:29:15 -0800 (PST) Sender: Baptiste Daroussin Date: Sat, 7 Nov 2015 17:29:14 +0100 From: Baptiste Daroussin To: Joerg Sonnenberger Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r290499 - head/usr.bin/localedef Message-ID: <20151107162913.GL31432@ivaldir.etoilebsd.net> References: <201511071622.tA7GMTDN099727@repo.freebsd.org> <20151107162617.GA21271@britannica.bec.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="I4VOKWutKNZEOIPu" Content-Disposition: inline In-Reply-To: <20151107162617.GA21271@britannica.bec.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Nov 2015 16:29:18 -0000 --I4VOKWutKNZEOIPu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 07, 2015 at 05:26:17PM +0100, Joerg Sonnenberger wrote: > On Sat, Nov 07, 2015 at 04:22:29PM +0000, Baptiste Daroussin wrote: > > Author: bapt > > Date: Sat Nov 7 16:22:29 2015 > > New Revision: 290499 > > URL: https://svnweb.freebsd.org/changeset/base/290499 > >=20 > > Log: > > Workaround an issue on i386 to unbreak the build until the real issue= is tracked > > down > >=20 > > Modified: > > head/usr.bin/localedef/collate.c > >=20 > > Modified: head/usr.bin/localedef/collate.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/usr.bin/localedef/collate.c Sat Nov 7 15:03:45 2015 (r290498) > > +++ head/usr.bin/localedef/collate.c Sat Nov 7 16:22:29 2015 (r290499) > > @@ -1255,7 +1255,8 @@ dump_collate(void) > > * Large (> UCHAR_MAX) character priorities > > */ > > RB_NUMNODES(collchar_t, collchars, &collchars, n); > > - large =3D calloc(sizeof (collate_large_t) * n, 1); > > + large =3D malloc(sizeof (collate_large_t) * n); > > + memset(large, 0, sizeof (collate_large_t) * n); > > if (large =3D=3D NULL) { > > fprintf(stderr, "out of memory"); > > return; >=20 > Why was this not calloc(sizeof(), n) in first place?! I tried not to diverge too much from upstream (Illumos here), that is the reason. but the same issue happens with calloc(sizeof(), n) Issue being: : jemalloc_arena.c:353: Failed assertion: "p[i] =3D= =3D 0" Best regards, Bapt --I4VOKWutKNZEOIPu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlY+JtkACgkQ8kTtMUmk6ExymwCeLGPWn8G1YGlhgOYYpaxke4Ud rBsAoLkCMljFgQJ1HGLOtGlcm6yImSDH =sLgb -----END PGP SIGNATURE----- --I4VOKWutKNZEOIPu--