Date: Tue, 26 Jun 2012 21:06:06 +0200 From: Fabian Keil <freebsd-listen@fabiankeil.de> To: pfg@freebsd.org Cc: Mark Peek <mp@FreeBSD.org>, freebsd-current@FreeBSD.org Subject: Re: [RFT] llquantize for FreeBSD's dtrace Message-ID: <20120626210606.632498e2@fabiankeil.de> In-Reply-To: <1340735734.53528.YahooMailClassic@web113510.mail.gq1.yahoo.com> References: <4FE9EFF9.9080507@FreeBSD.org> <1340735734.53528.YahooMailClassic@web113510.mail.gq1.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/KhepE2o_8pVy__SoG_Oy.Cm Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Pedro Giffuni <pfg@freebsd.org> wrote: > --- Mar 26/6/12, Mark Peek <mp@FreeBSD.org> ha scritto: > > Try this, change the assert on line 1429 in file dt_cc.c > > from: > >=20 > > assert(!(arg & (UINT16_MAX << args[i].shift))); > >=20 > > to > >=20 > > assert(!(arg & ((uint64_t)UINT16_MAX << > > args[i].shift))); > >=20 >=20 > This certainly looks correct. Thanks Mark ! >=20 > I updated the patch: >=20 > http://people.freebsd.org/~pfg/patches/patch-dtrace-llquantize Thanks a lot. Seems to work for me: fk@r500 /usr/src/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquan= tize $for t in tst.*.d; do sudo dtrace -s $t > $t.myout; diff $t.out $t.myo= ut && echo success for $t; done success for tst.bases.d success for tst.basic.d success for tst.negorder.d success for tst.negvalue.d success for tst.normal.d success for tst.range.d success for tst.steps.d success for tst.trunc.d fk@r500 /usr/src/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquan= tize $for t in err.*.d; do sudo dtrace -s $t dtrace: failed to compile script err.D_LLQUANT_FACTOREVEN.nodivide.d: line = 28: llquantize( ) factor (argument #1) must evenly divide the number of ste= ps per magnitude (argument #4), and the number of steps per magnitude must = evenly divide a power of the factor dtrace: failed to compile script err.D_LLQUANT_FACTOREVEN.notfactor.d: line= 28: llquantize( ) factor (argument #1) must evenly divide the number of st= eps per magnitude (argument #4), and the number of steps per magnitude must= evenly divide a power of the factor dtrace: failed to compile script err.D_LLQUANT_FACTORMATCH.d: line 29: llqu= antize( ) factor (argument #1) doesn't match previous declaration: expected= 10, found 3 dtrace: failed to compile script err.D_LLQUANT_FACTORNSTEPS.d: line 28: llq= uantize( ) factor (argument #1) must be less than or equal to the number of= linear steps per magnitude (argument #4) dtrace: failed to compile script err.D_LLQUANT_FACTORSMALL.d: line 28: llqu= antize( ) factor (argument #1) must be two or more dtrace: failed to compile script err.D_LLQUANT_FACTORTYPE.d: line 29: llqua= ntize( ) argument #1 (factor) must be an integer constant dtrace: failed to compile script err.D_LLQUANT_FACTORVAL.d: line 28: llquan= tize( ) argument #1 (factor) must be an unsigned 16-bit quantity dtrace: failed to compile script err.D_LLQUANT_HIGHMATCH.d: line 29: llquan= tize( ) high magnitude (argument #3) doesn't match previous declaration: ex= pected 10, found 11 dtrace: failed to compile script err.D_LLQUANT_HIGHTYPE.d: line 29: llquant= ize( ) argument #3 (high magnitude) must be an integer constant dtrace: failed to compile script err.D_LLQUANT_HIGHVAL.d: line 28: llquanti= ze( ) argument #3 (high magnitude) must be an unsigned 16-bit quantity dtrace: failed to compile script err.D_LLQUANT_LOWMATCH.d: line 29: llquant= ize( ) low magnitude (argument #2) doesn't match previous declaration: expe= cted 0, found 1 dtrace: failed to compile script err.D_LLQUANT_LOWTYPE.d: line 29: llquanti= ze( ) argument #2 (low magnitude) must be an integer constant dtrace: failed to compile script err.D_LLQUANT_LOWVAL.d: line 28: llquantiz= e( ) argument #2 (low magnitude) must be an unsigned 16-bit quantity dtrace: failed to compile script err.D_LLQUANT_MAGRANGE.d: line 28: llquant= ize( ) high magnitude (argument #3) must be greater than low magnitude (arg= ument #2) dtrace: failed to compile script err.D_LLQUANT_MAGTOOBIG.d: line 28: llquan= tize( ) factor (10) raised to power of high magnitude (100) overflows 64-bi= ts dtrace: failed to compile script err.D_LLQUANT_NSTEPMATCH.d: line 29: llqua= ntize( ) linear steps per magnitude (argument #4) doesn't match previous de= claration: expected 10, found 100 dtrace: failed to compile script err.D_LLQUANT_NSTEPTYPE.d: line 29: llquan= tize( ) argument #4 (linear steps per magnitude) must be an integer constant dtrace: failed to compile script err.D_LLQUANT_NSTEPVAL.d: line 28: llquant= ize( ) argument #4 (linear steps per magnitude) must be an unsigned 16-bit = quantity Fabian --Sig_/KhepE2o_8pVy__SoG_Oy.Cm Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/qCCoACgkQBYqIVf93VJ37twCeIGTaWwrMpUxhes6bH4JTuFMO VNEAoJP/R+W9WDebvaKy74DQGInWp2zo =CS2E -----END PGP SIGNATURE----- --Sig_/KhepE2o_8pVy__SoG_Oy.Cm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120626210606.632498e2>