From owner-cvs-all@FreeBSD.ORG  Mon Jul  5 07:50:21 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8781B106564A;
	Mon,  5 Jul 2010 07:50:21 +0000 (UTC)
	(envelope-from ehaupt@FreeBSD.org)
Received: from mx.critical.ch (cl-8.zrh-02.ch.sixxs.net
	[IPv6:2001:1620:f00:7::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 08A1E8FC08;
	Mon,  5 Jul 2010 07:50:20 +0000 (UTC)
Received: from wiggles.bwns.ch (localhost [IPv6:::1])
	by mx.critical.ch (8.14.3/8.14.3/critical-1.0) with SMTP id
	o657oJKo077404; Mon, 5 Jul 2010 09:50:19 +0200 (CEST)
	(envelope-from ehaupt@FreeBSD.org)
Date: Mon, 5 Jul 2010 09:50:19 +0200
From: Emanuel Haupt <ehaupt@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Message-Id: <20100705095019.1b16a029.ehaupt@FreeBSD.org>
In-Reply-To: <20100705072144.GA47205@FreeBSD.org>
References: <201007010647.o616lMdP059532__40956.557825166$1277966864$gmane$org@repoman.freebsd.org>
	<86iq4uxvzp.fsf@gmail.com>
	<20100705090015.0e97934e.ehaupt@FreeBSD.org>
	<20100705072144.GA47205@FreeBSD.org>
X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; amd64-portbld-freebsd8.1)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Anonymous <swell.k@gmail.com>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org,
	Emanuel Haupt <ehaupt@FreeBSD.org>, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/audio/xmp Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jul 2010 07:50:21 -0000

Alexey Dokuchaev <danfe@FreeBSD.ORG> wrote:
> On Mon, Jul 05, 2010 at 09:00:15AM +0200, Emanuel Haupt wrote:
> > Anonymous <swell.k@gmail.com> wrote:
> > > Emanuel Haupt <ehaupt@FreeBSD.org> writes:
> > > 
> > > > ehaupt      2010-07-01 06:47:22 UTC
> > > >
> > > >   FreeBSD ports repository
> > > >
> > > >   Modified files:
> > > >     audio/xmp            Makefile 
> > > >   Log:
> > > >   Prevent unconditional linking against ALSA
> > > 
> > > Hmm, and why you untabified ALSA option?
> > > 
> > > It's inconsistent with other options. Turn on whitespace-mode (in
> > > emacs) and see for yourself.
> > 
> > Good catch, it's due to a copy pasta [1] glicht. I'll fix it in the
> > upcoming release.
> 
> These are pretty easy to avoid, just do "grep '  ' *" and "grep ' $'
> *" in the port directory before committing (like I always do, in
> addition to portlint(1)).

Portlint wouldn't have cought it, since the spaces were here:

OPTIONS=        ALSA    "ALSA output driver" off \
                    ^^^^

I and many others often use spaces in that part of the options section.
In this case it just wasn't consistent with the other options, which is
due to copy pasting.

Emanuel