From owner-cvs-all@FreeBSD.ORG Thu Jun 9 23:26:05 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A844016A41F for ; Thu, 9 Jun 2005 23:26:05 +0000 (GMT) (envelope-from john@baldwin.cx) Received: from mail22.sea5.speakeasy.net (mail22.sea5.speakeasy.net [69.17.117.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DD9A43D4C for ; Thu, 9 Jun 2005 23:26:04 +0000 (GMT) (envelope-from john@baldwin.cx) Received: (qmail 19189 invoked from network); 9 Jun 2005 23:26:03 -0000 Received: from server.baldwin.cx ([216.27.160.63]) (envelope-sender ) by mail22.sea5.speakeasy.net (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for ; 9 Jun 2005 23:26:02 -0000 Received: from [10.2.245.235] ([206.13.39.65]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j59NPsnA065755; Thu, 9 Jun 2005 19:25:55 -0400 (EDT) (envelope-from john@baldwin.cx) In-Reply-To: <200506091943.j59Jh8H3058277@repoman.freebsd.org> References: <200506091943.j59Jh8H3058277@repoman.freebsd.org> Mime-Version: 1.0 (Apple Message framework v622) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <692e14e0d72d5737f1c12f3c8def892d@baldwin.cx> Content-Transfer-Encoding: 7bit From: John Baldwin Date: Thu, 9 Jun 2005 16:25:15 -0700 To: Stephan Uphoff X-Mailer: Apple Mail (2.622) X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_switch.c sched_4bsd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2005 23:26:05 -0000 On Jun 9, 2005, at 12:43 PM, Stephan Uphoff wrote: > ups 2005-06-09 19:43:08 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_switch.c sched_4bsd.c > Log: > Lots of whitespace cleanup. > Fix for broken if condition. > > Submitted by: nate@ What was broken about the if test? The intention was that when FULL_PREEMPTION was off, we only preempt if the destination thread is an ithread or if the current thread is an idle priority thread. I think you've changed it so that we never preempt if the current thread is an idle thread now, which is very bad. I took out explicit calls to mi_switch() in the page zeroing thread in reliance on the behavior that we always preempt an idle priority thread. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org