From owner-freebsd-hardware@FreeBSD.ORG Sat Jun 12 18:16:09 2004 Return-Path: Delivered-To: freebsd-hardware@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9CA316A4CE; Sat, 12 Jun 2004 18:16:09 +0000 (GMT) Received: from crumpet.united-ware.com (ddsl-66-42-172-210.fuse.net [66.42.172.210]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35A3C43D39; Sat, 12 Jun 2004 18:16:09 +0000 (GMT) (envelope-from mistry.7@osu.edu) Received: from [192.168.0.6] (adsl-64-109-102-183.dsl.wotnoh.ameritech.net [64.109.102.183]) (authenticated bits=0)i5CI8nQr044533 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sat, 12 Jun 2004 14:08:51 -0400 (EDT) (envelope-from mistry.7@osu.edu) From: Anish Mistry To: freebsd-hardware@freebsd.org Date: Sat, 12 Jun 2004 14:15:59 -0400 User-Agent: KMail/1.6.2 References: <200406121245.i5CCjTOZ011659@smsgw.vianetworks.ch> In-Reply-To: <200406121245.i5CCjTOZ011659@smsgw.vianetworks.ch> MIME-Version: 1.0 Content-Disposition: inline Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <200406121416.07647.mistry.7@osu.edu> X-Spam-Status: No, hits=-4.9 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,PGP_SIGNATURE, QUOTED_EMAIL_TEXT,RCVD_IN_ORBS,REFERENCES, REPLY_WITH_QUOTES,USER_AGENT_KMAIL version=2.55 X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: Markus Wild Subject: Re: Fix for Logitech DiNovo cordless mouse [PATCH] X-BeenThere: freebsd-hardware@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: General discussion of FreeBSD hardware List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2004 18:16:10 -0000 =2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Saturday 12 June 2004 08:45 am, Markus Wild wrote: > Hm, I had a look through the patched files, and one thing that sprung > to my eyes: the FreeBSD hid_report_size(() function is currently used > to both return the size of a report, as well as setting the device > report ID (the ID parameter is of type "out"). This ID is later used > to match incoming reports to the device. With the suggested > changes, this parameter changes to being of type "in", i.e. the > function no longer returns the ID information to the calling function. > This would certainly generate a compile time warning (if not error) > for ums.c, and while uhid.c has been syntactically changed, I now see > no place where sc->sc_iid, sc->sc_oid, sc->sc_fid would be initialized > after applying the change. I assume the NetBSD code in itself is sound, > so perhaps we're just missing additional files now that would also need > to be changed for FreeBSD? > You're right, I missed a couple files. This is starting to turn a bit messy= ,=20 but it'll be better to sync it up now rather than later. I'm going to try = to=20 get a better patch this weekend. =2D --=20 Anish Mistry =2D----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAy0hmxqA5ziudZT0RAikEAJoDzFMcgyXtiZ3xWiSepVVgJzFiegCgqgsr JoH9RSdTshG5Z5F18HS3w2Y=3D =3DZGKF =2D----END PGP SIGNATURE-----