From owner-freebsd-net@FreeBSD.ORG  Tue Mar 20 19:04:02 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 17DA6106566C;
	Tue, 20 Mar 2012 19:04:02 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id DD08C8FC0A;
	Tue, 20 Mar 2012 19:04:01 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
	by cyrus.watson.org (Postfix) with ESMTPSA id 907F146B17;
	Tue, 20 Mar 2012 15:04:01 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id F160FB91C;
	Tue, 20 Mar 2012 15:04:00 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Jason Wolfe <nitroboost@gmail.com>
Date: Tue, 20 Mar 2012 14:57:24 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; )
References: <CAAAm0r3Qj+2rf8cx54bcyAXGQezcE8J=xXYPq4W-jDy75r8qew@mail.gmail.com>
	<201203151417.04507.jhb@freebsd.org>
	<CAAAm0r0JxpHdq9CS=uwWysojXv_K-iT_NOb_fTeKAiAE_w8nbQ@mail.gmail.com>
In-Reply-To: <CAAAm0r0JxpHdq9CS=uwWysojXv_K-iT_NOb_fTeKAiAE_w8nbQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201203201457.24776.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Tue, 20 Mar 2012 15:04:01 -0400 (EDT)
Cc: freebsd-net@freebsd.org, Adrian Chadd <adrian@freebsd.org>,
	Hooman Fazaeli <hoomanfazaeli@gmail.com>
Subject: Re: Intel 82574L interface wedging - em7.3.2/8.2-STABLE
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2012 19:04:02 -0000

On Tuesday, March 20, 2012 1:45:32 pm Jason Wolfe wrote:
> On Thu, Mar 15, 2012 at 11:17 AM, John Baldwin <jhb@freebsd.org> wrote:
> > On Sunday, March 11, 2012 3:47:07 am Hooman Fazaeli wrote:
> >> On 3/11/2012 5:31 AM, Adrian Chadd wrote:
> >> > Are you able to post the patch here?
> >> > Maybe Jack can look at what's going on and apply it to the latest
> >> > intel ethernet driver.
> >> >
> >> >
> >> > Adrian
> >> >
> >>
> >> Below is the patch for if_em.c (7.2.3). It simply checks driver's
> >> queue status when the link state changes (inactive -> active) and
> >> start transmit task if queue(s) are not empty.
> >>
> >> It also contains stuff I have added to compile on 7 plus some code
> >> for test and diagnostics.
> >
> > Hmm, so I have yet to test this, but I found several bugs related to 
transmit
> > in em(4) and igb(4) recently just reading the code.  (Mostly unnecessary
> > scheduling of tasks for transmit.)  I've included your change of 
restarting
> > TX when link becomes active.  I've also updated it to fix resume for em
> > and igb to DTRT when buf_ring is used, and to not include old-style start
> > routines at all when using multiq.  It is at
> > http://www.freebsd.org/~jhb/patches/e1000_txeof2.patch
> >
> > --
> > John Baldwin
> 
> John/Hooman,
> 
> Thank for the patch sirs, so far it does look like it did the trick.
> I'll know for certain here in a few days if I'm still in the clear.
> I'm guessing after it goes through some more testing it'll be too late
> to slip it into 8.3?

Yes, this is too late for 8.3, but thanks for testing!

-- 
John Baldwin