From owner-svn-ports-head@freebsd.org  Tue Jan 30 17:55:00 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A267ED8CB2;
 Tue, 30 Jan 2018 17:55:00 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id CE55078C05;
 Tue, 30 Jan 2018 17:54:59 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id C6CA1140E0; Tue, 30 Jan 2018 17:54:59 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Niclas Zeising <zeising@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r460417 - in head/x11-wm/dwm: . files
References: <201801301728.w0UHSYQU096346@repo.freebsd.org>
Date: Tue, 30 Jan 2018 18:54:52 +0100
In-Reply-To: <201801301728.w0UHSYQU096346@repo.freebsd.org> (Niclas Zeising's
 message of "Tue, 30 Jan 2018 17:28:34 +0000 (UTC)")
Message-ID: <fu6n-fd03-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jan 2018 17:55:00 -0000

Niclas Zeising <zeising@FreeBSD.org> writes:

> Author: zeising
> Date: Tue Jan 30 17:28:34 2018
> New Revision: 460417
> URL: https://svnweb.freebsd.org/changeset/ports/460417
>
> Log:
>   Add a configuration knob to allow the usage of the super key instead of alt
>   as modifier.
[...]
> @@ -0,0 +1,11 @@
> +--- config.def.h.orig	2018-01-16 16:05:12 UTC
> ++++ config.def.h
> +@@ -42,7 +42,7 @@ static const Layout layouts[] = {
> + };
> + 
> + /* key definitions */
> +-#define MODKEY Mod1Mask
> ++#define MODKEY Mod4Mask

What is the rationale for patching config.def.h instead of one's own
config.h via DWM_CONF variable in make.conf(5) ? I don't follow how a
*non-default* option has any value here.