From owner-freebsd-ports@FreeBSD.ORG  Mon Feb 23 04:44:01 2004
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E5E7916A4CE
	for <freebsd-ports@freebsd.org>; Mon, 23 Feb 2004 04:44:01 -0800 (PST)
Received: from postman.arcor.de (postman4.arcor-online.net [151.189.0.154])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5FF0443D31
	for <freebsd-ports@freebsd.org>; Mon, 23 Feb 2004 04:44:01 -0800 (PST)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from fillmore.dyndns.org (port-212-202-51-138.reverse.qsc.de
	[212.202.51.138])	(authenticated bits=0)i1NChxUa014172
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Mon, 23 Feb 2004 13:43:59 +0100 (MET)
Received: from [172.16.0.2] (helo=fillmore-labs.com)
	by fillmore.dyndns.org with esmtp (Exim 4.30; FreeBSD)
	id 1AvFRF-000Eo7-4x; Mon, 23 Feb 2004 13:43:57 +0100
Message-ID: <4039F58C.1020004@fillmore-labs.com>
Date: Mon, 23 Feb 2004 13:43:56 +0100
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/
MIME-Version: 1.0
To: Thomas-Martin Seck <tmseck-lists@netcologne.de>
References: <20040223120917.608.qmail@laurel.tmseck.homedns.org>
In-Reply-To: <20040223120917.608.qmail@laurel.tmseck.homedns.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: KMail/1.5.9
cc: freebsd-ports@freebsd.org
Subject: Re: OPTIONS, LATEST_LINK, and RCng
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 12:44:02 -0000

Thomas-Martin Seck wrote:

> [...]
> 
> No, the script is rcNG _aware_. If rc.subr is not present in the two
> locations where the scripts expects it to be, the script will just
> behave like any other rc script. An added bonus is that you get reload,
> restart, and status functions from rcNG.

I believe that is confusing, since the script will start without requiring
enable_dansguardian="YES" in /etc/rc.conf if and only if rc.subr is on your
system, which means that it changes its behaviour when I install/deinstall
other ports.

Btw, you script is missing enable_dansguardian=${enable_dansguardian:-"NO"}
before load_rc_config.

>> [...]
>>
>>You should just USE_RC_SUBR=yes with
> 
> I deliberately avoided this dependency for the squid ports since rcNG is
> not needed for this port to work. If users want rcNG on pre-rcNG
> systems, they can install the rc_subr themselves and the squid start
> scripts will then use rcNG.

See above.  Just USE_RC_SUBR, as everybody does, I'll file a PR against the
squid ports.