Date: Fri, 12 Mar 2004 13:00:38 -0500 (EST) From: Trevor Johnson <trevor@jpj.net> To: Clement Laforet <sheepkiller@cultdeadsheep.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11-wm/piewm Makefile Message-ID: <20040312123554.N12343@blues.jpj.net> In-Reply-To: <20040312181312.30318f54.sheepkiller@cultdeadsheep.org> References: <200403121625.i2CGPIho015269@repoman.freebsd.org> <20040312181312.30318f54.sheepkiller@cultdeadsheep.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > Set DISABLE_SIZE to avoid "size unknown" error. > > According to: > http://lists.freebsd.org/mailman/htdig/freebsd-ports/2004-March/010217.html > you should use NO_SIZE NO_SIZE prevents SIZE lines from being added to the MD5_FILE, whereas DISABLE_SIZE suppresses the size-checking. The comment in bsd.port.mk about NO_SIZE is something I wrote when I proposed NO_SIZE and didn't know that DISABLE_SIZE would be added. DISABLE_SIZE is IMO better for this sort of situation because it lets the size lines remain even though they are not checked. Jason Harris mentioned to me that having the size data can be useful when a port is unfetchable and one goes searching for the distfile. It can also be of some use if a user manually looks at it to get an idea of the time and disk space needed to download the distfile. I don't know of a reason why DISABLE_SIZE must only be set by the user. The comments in bsd.port.mk could be changed: Index: /usr/ports/Mk/bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.484 diff -u -r1.484 bsd.port.mk --- /usr/ports/Mk/bsd.port.mk 4 Feb 2004 04:27:04 -0000 1.484 +++ /usr/ports/Mk/bsd.port.mk 12 Mar 2004 17:50:36 -0000 @@ -732,10 +732,9 @@ # # For makesum: # -# NO_SIZE - Don't record size data in distinfo, needed -# when the master site does not report file -# sizes, or when multiple valid versions of -# a distfile, having different sizes, exist. +# NO_SIZE - Don't record size data in distinfo, needed +# when multiple valid versions of a distfile, +# having different sizes, exist. # # For patch: # @@ -876,7 +875,8 @@ # for systems where you have no root access. # DISABLE_SIZE - Do not check the size of a distfile even if the SIZE field # has been specified in distinfo. This is useful -# when using an alternate FETCH_CMD. +# when using an alternate FETCH_CMD, or when a master site does +# not report file sizes ("size unknown" error). # # End of the list of all variables that need to be defined in a port. # Most port authors should not need to understand anything after this point. -- Trevor Johnson
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040312123554.N12343>