From owner-freebsd-net@FreeBSD.ORG Wed Jan 19 17:42:11 2005 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8194E16A4CE; Wed, 19 Jan 2005 17:42:11 +0000 (GMT) Received: from relay.bestcom.ru (relay.bestcom.ru [217.72.144.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id B951243D31; Wed, 19 Jan 2005 17:42:10 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (root@cell.sick.ru [217.72.144.68]) by relay.bestcom.ru (8.13.1/8.12.9) with ESMTP id j0JHfwQB035987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 19 Jan 2005 20:42:03 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id j0JHfvqo010603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 Jan 2005 20:41:58 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id j0JHfuhO010602; Wed, 19 Jan 2005 20:41:56 +0300 (MSK) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Wed, 19 Jan 2005 20:41:56 +0300 From: Gleb Smirnoff To: Brooks Davis Message-ID: <20050119174156.GA10573@cell.sick.ru> References: <20050117200610.GA90866@cell.sick.ru> <20050118183558.GA15150@odin.ac.hmc.edu> <41ED8D63.8090205@elischer.org> <20050119084526.GA5119@cell.sick.ru> <41EE2933.4090404@elischer.org> <20050119093608.GA5712@cell.sick.ru> <41EE3361.8D27FF5B@freebsd.org> <20050119123426.GA7825@cell.sick.ru> <20050119165751.GA19365@odin.ac.hmc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20050119165751.GA19365@odin.ac.hmc.edu> User-Agent: Mutt/1.5.6i X-Virus-Scanned: ClamAV version devel-20050119, clamav-milter version 0.80ff on relay.bestcom.ru X-Virus-Status: Clean cc: Andre Oppermann cc: Julian Elischer cc: net@freebsd.org Subject: Re: [TEST/REVIEW] ng_ipfw: node to glue together ipfw(4) andnetgraph(4) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2005 17:42:11 -0000 On Wed, Jan 19, 2005 at 08:57:51AM -0800, Brooks Davis wrote: B> Off the top of my head, I don't like the idea. What are the savings in B> doing so? Is there a guarantee that you won't need more then one at B> once? Well, I've spent enough braincycles arguing with myself, so I ask you to decide "to merge or not to merge" between yourself, and them I'll accept any decision. P.S. Pls note, that I've added 'if (DIVERT_LOADED)', and were asked for a backout. This was done to avoid tag lookup in a case, when tag can not be present. I've intentionally didn't add 'if (NG_IPFW_LOADED)' here. However, I don't agree with this... -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE