From owner-svn-ports-all@freebsd.org  Wed Sep  2 13:10:38 2015
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C03279C801E;
 Wed,  2 Sep 2015 13:10:38 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2623E88B;
 Wed,  2 Sep 2015 13:10:37 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 777f3135
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Wed, 2 Sep 2015 07:10:28 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: svn commit: r395135 - in head/www: . p5-HTTP-CookieMonster
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <CAALwa8=25h=hS9GP7vZk7qTddyD9ZSQms6ey4UikTOuXDvTswg@mail.gmail.com>
Date: Wed, 2 Sep 2015 07:10:26 -0600
Cc: Jun Kuriyama <kuriyama@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1BDE4ADA-93D2-4CB8-AB8D-EC6CBE1B3E67@adamw.org>
References: <201508232218.t7NMIWS8046906@repo.freebsd.org>
 <CAALwa8=25h=hS9GP7vZk7qTddyD9ZSQms6ey4UikTOuXDvTswg@mail.gmail.com>
To: Antoine Brodin <antoine@FreeBSD.org>
X-Mailer: Apple Mail (2.2104)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Sep 2015 13:10:38 -0000

> On 2 Sep, 2015, at 0:01, Antoine Brodin <antoine@FreeBSD.org> wrote:
>=20
> On Mon, Aug 24, 2015 at 12:18 AM, Jun Kuriyama <kuriyama@freebsd.org> =
wrote:
>> Author: kuriyama
>> Date: Sun Aug 23 22:18:32 2015
>> New Revision: 395135
>> URL: https://svnweb.freebsd.org/changeset/ports/395135
>>=20
>> Log:
>>  This module was created because messing around with HTTP::Cookies is
>>  non-trivial.  HTTP::Cookies a very useful module, but using it is =
not
>>  always as easy and clean as it could be.
>>=20
>>  WWW: http://search.cpan.org/dist/HTTP-CookieMonster/
> ...
>> Added: head/www/p5-HTTP-CookieMonster/Makefile
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
>> +++ head/www/p5-HTTP-CookieMonster/Makefile     Sun Aug 23 22:18:32 =
2015        (r395135)
> ...
>> +RUN_DEPENDS=3D   \
>> +       p5-HTTP-Cookies>0:${PORTSDIR}/www/p5-HTTP-Cookies \
>> +       p5-Moo>=3D1.000003:${PORTSDIR}/devel/p5-Moo \
>> +       p5-Safe-Isa>0:${PORTSDIR}/devel/p5-Safe-Isa \
>> +       p5-Sub-Exporter>0:${PORTSDIR}/devel/p5-Sub-Exporter \
>> +       p5-URI>0:${PORTSDIR}/net/p5-Net
> ...
>=20
> Hi,
>=20
> The p5-URI/p5-Net line looks wrong.
>=20
> Cheers,
>=20
> Antoine
>=20

As does
	BUILD_DEPENDS=3D	${RUN_DEPENDS}
and the mis-sorted plist.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org