From owner-svn-ports-head@FreeBSD.ORG  Tue Dec 31 10:40:20 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 39B5375E;
 Tue, 31 Dec 2013 10:40:20 +0000 (UTC)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 by mx1.freebsd.org (Postfix) with ESMTP id 121BB166A;
 Tue, 31 Dec 2013 10:40:19 +0000 (UTC)
Received: from [192.168.1.2] (unknown [121.97.136.167])
 by ainaz.pair.com (Postfix) with ESMTPSA id E2E603F412;
 Tue, 31 Dec 2013 05:40:08 -0500 (EST)
User-Agent: K-9 Mail for Android
In-Reply-To: <201312252329.rBPNTY87062947@svn.freebsd.org>
References: <201312252329.rBPNTY87062947@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: svn commit: r337464 - in head: audio/alure audio/fpc-openal
 audio/freealut audio/hs-ALUT audio/hs-OpenAL audio/py-al audio/py-openal
 deskutils/xneur devel/allegro-devel devel/love devel/love07 deve...
From: Gerald Pfeifer <gerald@pfeifer.com>
Date: Tue, 31 Dec 2013 18:22:01 +0800
To: Antoine Brodin <antoine@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Message-ID: <9085f71d-db56-4f8d-9911-461c7a87d47c@email.android.com>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Dec 2013 10:40:20 -0000

Antoine Brodin <antoine@FreeBSD.org> wrote:
>Log:
>  Convert the tree to USES=openal
>  
>  Approved by:	portmgr (bapt)

>Modified: head/emulators/wine-devel/Makefile
>==============================================================================
>--- head/emulators/wine-devel/Makefile	Wed Dec 25 23:24:54
>2013	(r337463)
>+++ head/emulators/wine-devel/Makefile	Wed Dec 25 23:29:34
>2013	(r337464)
>@@ -53,6 +53,9 @@ WINEMAKER_DESC=	Fully support winemaker 
> GECKO_DESC=	Bundle Gecko MSI package for Wine
> MONO_DESC=	Bundle Mono MSI package for Wine
> 
>+# USES needs to be before bsd.port.pre.mk
>+OPENAL_USES=	openal
>+
> PORTDATA=	l_intl.nls wine.inf
> 
> .include <bsd.port.pre.mk>
>@@ -98,7 +101,6 @@ CONFIGURE_ARGS+=	--without-xslt
> 
> .if ${PORT_OPTIONS:MOPENAL}
> CONFIGURE_ARGS+=	--with-openal
>-USE_OPENAL=		yes
> .else
> CONFIGURE_ARGS+=	--without-openal
> .endif
>
>Modified: head/emulators/wine/Makefile
>==============================================================================
>--- head/emulators/wine/Makefile	Wed Dec 25 23:24:54 2013	(r337463)
>+++ head/emulators/wine/Makefile	Wed Dec 25 23:29:34 2013	(r337464)
>@@ -58,6 +58,9 @@ WINEMAKER_DESC=	Fully support winemaker 
> GECKO_DESC=	Bundle Gecko MSI package for Wine
> MONO_DESC=	Bundle Mono MSI package for Wine
> 
>+# USES needs to be before bsd.port.pre.mk
>+OPENAL_USES=	openal
>+
> PORTDATA=	fonts/ generic.ppd l_intl.nls wine.inf
> 
> PORTSCOUT=	limitw:1,even
>@@ -105,7 +108,6 @@ CONFIGURE_ARGS+=	--without-xslt
> 
> .if ${PORT_OPTIONS:MOPENAL}
> CONFIGURE_ARGS+=	--with-openal
>-USE_OPENAL=		yes
> PLIST_SUB+=		OPENAL=""
> .else
> CONFIGURE_ARGS+=	--without-openal

Per my earlier mail I am pretty hampered accessing FreeBSD code right now, but...is this really right?
Pulling in OpenAL unconditionally for  these two ports looks strange to me; definitely not intuitive.

Gerald

-- 
Gerald Pfeifer <gerald@pfeifer.com>