Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Aug 2015 19:34:49 -0300
From:      Luiz Otavio O Souza <loos.br@gmail.com>
To:        =?UTF-8?Q?Ermal_Lu=C3=A7i?= <ermal.luci@gmail.com>
Cc:        Luiz Otavio O Souza <loos@freebsd.org>, src-committers <src-committers@freebsd.org>,  svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r287009 - in head: sbin/pfctl share/man/man4 sys/conf sys/net/altq sys/netpfil/pf
Message-ID:  <CAJ8CS7o31ZiHtGyesW8e1YaxEmEa95goGhLT1zqxfmFzr_Yc8g@mail.gmail.com>
In-Reply-To: <CAPBZQG3MJVgJ%2BaZvpxrFeDdvdc-Mf%2BxGmVJ_3pcTs2Oy23Ou9A@mail.gmail.com>
References:  <201508212202.t7LM2MhF015522@repo.freebsd.org> <CAPBZQG3MJVgJ%2BaZvpxrFeDdvdc-Mf%2BxGmVJ_3pcTs2Oy23Ou9A@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 22, 2015 at 6:18 AM, Ermal Lu=C3=A7i wrote:
>
>
> On Sat, Aug 22, 2015 at 12:02 AM, Luiz Otavio O Souza
> wrote:
>>
>> Author: loos
>> Date: Fri Aug 21 22:02:22 2015
>> New Revision: 287009
>> URL: https://svnweb.freebsd.org/changeset/base/287009
>>
>> Log:
>>   Add ALTQ(9) support for the CoDel algorithm.
>>
>>   CoDel is a parameterless queue discipline that handles variable
>> bandwidth
>>   and RTT.
>>
>>   It can be used as the single queue discipline on an interface or as a
>> sub
>>   discipline of existing queue disciplines such as PRIQ, CBQ, HFSC, FAIR=
Q.
>>
>>   Differential Revision:        https://reviews.freebsd.org/D3272
>>   Reviewd by:   rpaulo, gnn (previous version)
>
>
> I thought part of this commit message was taken from me as a reviewer, no=
?

Sorry Ermal, my bad. As you only commented and not accepted the review
I thought you don't want to be implied with a reviewed by.

[...]

>> Added: head/sys/net/altq/altq_codel.c
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
>> +++ head/sys/net/altq/altq_codel.c      Fri Aug 21 22:02:22 2015
>> (r287009)
>> @@ -0,0 +1,477 @@
>> +/*
>> + * CoDel - The Controlled-Delay Active Queue Management algorithm
>> + *
>> + *  Copyright (C) 2013 Ermal Luci <eri@FreeBSD.org>
>
>
> Can you correct my name?
>

Sure, I'll commit the fix soon (probably on monday) I'm AFK this weekend.

I really appreciate your work on Codel.

Regards,
Luiz



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ8CS7o31ZiHtGyesW8e1YaxEmEa95goGhLT1zqxfmFzr_Yc8g>