From owner-svn-src-all@FreeBSD.ORG  Fri Jan  9 20:38:22 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 116C31065672;
	Fri,  9 Jan 2009 20:38:22 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id F2E838FC1E;
	Fri,  9 Jan 2009 20:38:21 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n09KcLD3067836;
	Fri, 9 Jan 2009 20:38:21 GMT (envelope-from mav@svn.freebsd.org)
Received: (from mav@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n09KcLDf067835;
	Fri, 9 Jan 2009 20:38:21 GMT (envelope-from mav@svn.freebsd.org)
Message-Id: <200901092038.n09KcLDf067835@svn.freebsd.org>
From: Alexander Motin <mav@FreeBSD.org>
Date: Fri, 9 Jan 2009 20:38:21 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
X-SVN-Group: stable-7
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r186969 - in stable/7/sys: . contrib/pf dev/ath/ath_hal
	dev/cxgb netgraph
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jan 2009 20:38:22 -0000

Author: mav
Date: Fri Jan  9 20:38:21 2009
New Revision: 186969
URL: http://svn.freebsd.org/changeset/base/186969

Log:
  MFC rev. 185179
  
  Remove unneeded NULL check. At first msg can't be null here and and at second
  NG_FREE_MSG() also checks it.
  
  Found with:	Coverity Prevent(tm)

Modified:
  stable/7/sys/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)
  stable/7/sys/dev/ath/ath_hal/   (props changed)
  stable/7/sys/dev/cxgb/   (props changed)
  stable/7/sys/netgraph/ng_base.c

Modified: stable/7/sys/netgraph/ng_base.c
==============================================================================
--- stable/7/sys/netgraph/ng_base.c	Fri Jan  9 20:34:32 2009	(r186968)
+++ stable/7/sys/netgraph/ng_base.c	Fri Jan  9 20:38:21 2009	(r186969)
@@ -2847,8 +2847,7 @@ ng_generic_msg(node_p here, item_p item,
 	 */
 out:
 	NG_RESPOND_MSG(error, here, item, resp);
-	if (msg)
-		NG_FREE_MSG(msg);
+	NG_FREE_MSG(msg);
 	return (error);
 }