From owner-svn-ports-all@freebsd.org Tue Mar 28 15:35:31 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A200FD206A5 for ; Tue, 28 Mar 2017 15:35:31 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: from mail.grem.de (outcast.grem.de [213.239.217.27]) by mx1.freebsd.org (Postfix) with SMTP id E4E1B9DE for ; Tue, 28 Mar 2017 15:35:30 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: (qmail 37238 invoked by uid 89); 28 Mar 2017 15:35:29 -0000 Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@194.97.158.70) by mail.grem.de with ESMTPA; 28 Mar 2017 15:35:29 -0000 Date: Tue, 28 Mar 2017 17:35:27 +0200 From: Michael Gmelin To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r437089 - in head/devel: . hhdate hhdate/files Message-ID: <20170328173527.55a12936@bsd64.grem.de> In-Reply-To: <20170328152612.GC20879@FreeBSD.org> References: <201703272235.v2RMZKfx024323@repo.freebsd.org> <20170328142701.GA20879@FreeBSD.org> <20170328165708.3feecd6a@bsd64.grem.de> <20170328152612.GC20879@FreeBSD.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd10.2) X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}> +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+ xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 15:35:31 -0000 On Tue, 28 Mar 2017 15:26:12 +0000 Alexey Dokuchaev wrote: > On Tue, Mar 28, 2017 at 04:57:08PM +0200, Michael Gmelin wrote: > > On Tue, 28 Mar 2017 14:27:01 +0000 > > Alexey Dokuchaev wrote: > > > ... > > > Bogus formatting (one extra tab after knobs), would you please > > > fix it? > > > > These are in to align to > > > > TEST_TEST_TARGET=test, otherwise it would look like this: > > > > TEST_USES= compiler:c++11-lib > > TEST_TEST_TARGET=test > > I'm not even sure why wrapping test-framework stuff in > options-framework, was it because of TEST_USES (since TEST_DEPENDS > was not really what you wanted)? The idea is that "make test" won't fail in case "TEST" wasn't set. c++11-lib is not a big deal, as these days we usually have clang as a system compiler that provides this anyway. In other cases you might pull in huge dependencies with the TEST knob though, so one might decide to not use tests for this specific port (e.g. pulls in clang39 or some other huge library by other DEPENDS), so if you disable it and still run make test (which we e.g. do for all ports when doing production builds) the build would fail. Hence only providing a test target if configured to do tests (the original version of the port skeleton had much more elaborate tests and will get them back once the maintainer contacted the author about a few unit tests that don't seem to make sense). > > > (replaced tabs by spaces for email) > > > > Would this actually be preferred? > > Options-support (helper) knobs are indeed longer than usual and might > require special care (esp. when mixed with shorter knobs) to get > pretty alignment, and that's OK since they are usually grouped > together after OPTIONS_DEFINE (or OPTIONS_DEFAULT -- since it also is > overly long). > > That said, there is no reason to double-tab standard width knobs that > preceed OPTIONS_DEFINE just to align them with what goes below it. > OPTIONS_DEFINE is a nice dividing line (esp. since it often gets quite > long as well). > > So, group longer option helper knobs and align within them, but don't > aling the entire Makefile with them. Makes sense, thank you. > > > > Any reason why option helper target (post-extract-TEST-on) was not > > > used here? > > > > Simply unaware it existed, so this would change to: > > > > post-extract-TEST-on: > > ${INSTALL_DATA} ${FILESDIR}/Makefile.in ${WRKSRC}/Makefile > > ${INSTALL_DATA} ${FILESDIR}/test-minimal.cpp ... > > Right; now don't take my word for it, rehash PHB and > `Mk/bsd.options.mk' and test changes thoroughly. :-) :) One slightly related question: While working on this port skeleton I wondered if it wouldn't make sense to chage Mk/Uses/compilers.mk to change the minimum default version of llvm for c++14. Right now we use llvm36, but other ports need newer versions and using the latest stable version would probably stop us from building multiple versions of llvm when building even just parts of the ports tree. -m -- Michael Gmelin