From owner-svn-ports-head@FreeBSD.ORG  Wed Jun 17 15:45:55 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D97F6876;
 Wed, 17 Jun 2015 15:45:55 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5E7E1CB7;
 Wed, 17 Jun 2015 15:45:54 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id eb044000;
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Wed, 17 Jun 2015 09:39:12 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
Subject: Re: svn commit: r389861 - in head/devel: cmake cmake-gui cmake-modules
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201506162025.t5GKP6lx080770@svn.freebsd.org>
Date: Wed, 17 Jun 2015 09:39:11 -0600
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <AD97DB22-EE1C-4779-A29F-EAEDA09E1E73@adamw.org>
References: <201506162025.t5GKP6lx080770@svn.freebsd.org>
To: Brad Davis <brd@FreeBSD.org>
X-Mailer: Apple Mail (2.2098)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jun 2015 15:45:56 -0000

> On 16 Jun, 2015, at 14:25, Brad Davis <brd@FreeBSD.org> wrote:
>=20
> Author: brd
> Date: Tue Jun 16 20:25:05 2015
> New Revision: 389861
> URL: https://svnweb.freebsd.org/changeset/ports/389861
>=20
> Log:
>  Update devel/cmake, devel/cmake-gui and devel/cmake-modules to 3.2.3.
>=20
> Modified: head/devel/cmake/Makefile
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>=20
> LIB_DEPENDS=3D	libcurl.so:${PORTSDIR}/ftp/curl \
> -		libexpat.so:${PORTSDIR}/textproc/expat2
> +		libexpat.so:${PORTSDIR}/textproc/expat2 \
> +		libjsoncpp.so:${PORTSDIR}/devel/jsoncpp

Does this port really need to depend on libjsoncpp? The version bundled =
with cmake works just fine (--no-system-jsoncpp).

The only benefit to making everybody install jsoncpp (and scons) would =
be if the jsoncpp port is updated more often than the cmake port. But =
the jsoncpp port hasn't had an update since the day it was added 16 =
months ago.

Can you please consider dropping the libjsoncpp dependency and just =
adding --no-system-jsoncpp to CONFIGURE_ARGS?

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org