Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Nov 2015 19:49:42 +0300
From:      Andrey Chernov <ache@freebsd.org>
To:        Baptiste Daroussin <bapt@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r290499 - head/usr.bin/localedef
Message-ID:  <563E2BA6.9020505@freebsd.org>
In-Reply-To: <201511071622.tA7GMTDN099727@repo.freebsd.org>
References:  <201511071622.tA7GMTDN099727@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 07.11.2015 19:22, Baptiste Daroussin wrote:
> Author: bapt
> Date: Sat Nov  7 16:22:29 2015
> New Revision: 290499
> URL: https://svnweb.freebsd.org/changeset/base/290499
> 
> Log:
>   Workaround an issue on i386 to unbreak the build until the real issue is tracked
>   down
> -	large = calloc(sizeof (collate_large_t) * n, 1);
> +	large = malloc(sizeof (collate_large_t) * n);
> +	memset(large, 0, sizeof (collate_large_t) * n);

Should be calloc(n, sizeof (collate_large_t)) according to calloc usage
and to prevent size_t overflow. Is it calloc() bug?

-- 
http://ache.vniz.net/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?563E2BA6.9020505>