From owner-cvs-all@FreeBSD.ORG  Sat Jan 14 22:58:47 2012
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id 9ACD8106566C;
	Sat, 14 Jan 2012 22:58:47 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id D639A150132;
	Sat, 14 Jan 2012 22:58:42 +0000 (UTC)
Message-ID: <4F1208A2.6070501@FreeBSD.org>
Date: Sat, 14 Jan 2012 14:58:42 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:9.0) Gecko/20111222 Thunderbird/9.0
MIME-Version: 1.0
To: Dirk Meyer <dinoex@FreeBSD.org>
References: <201201141452.q0EEqEeT052023@repoman.freebsd.org>
In-Reply-To: <201201141452.q0EEqEeT052023@repoman.freebsd.org>
X-Enigmail-Version: undefined
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/mail/rbl-milter/files rblmilter.sh.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jan 2012 22:58:47 -0000

These changes are completely useless, FYI.

I didn't not do this by accident. :)

Also, you're quoting, not escaping. And if you insist on quoting these
then the proper way to do it is to use single quotes, not double.
However, it's not necessary to quote them at all, and I would actually
prefer that you didn't do it at all.

And yes, I realize that there is a proliferation of bad examples to the
contrary. That's beside the point.


Doug


On 01/14/2012 06:52, Dirk Meyer wrote:
> dinoex      2012-01-14 14:52:13 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     mail/rbl-milter/files rblmilter.sh.in 
>   Log:
>   - escape shell names
>   
>   Revision  Changes    Path
>   1.4       +2 -2      ports/mail/rbl-milter/files/rblmilter.sh.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rbl-milter/files/rblmilter.sh.in.diff?&r1=1.3&r2=1.4&f=h
> 



-- 

	You can observe a lot just by watching.	-- Yogi Berra

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/