From owner-svn-src-all@FreeBSD.ORG Sun Mar 22 09:19:02 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 37B95106566C for ; Sun, 22 Mar 2009 09:19:02 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from xps.daemonology.net (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx2.freebsd.org (Postfix) with SMTP id 353B414F3D8 for ; Sun, 22 Mar 2009 09:19:01 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: (qmail 29445 invoked from network); 22 Mar 2009 09:17:29 -0000 Received: from unknown (HELO xps.daemonology.net) (127.0.0.1) by localhost with SMTP; 22 Mar 2009 09:17:29 -0000 Message-ID: <49C60229.2040400@freebsd.org> Date: Sun, 22 Mar 2009 02:17:29 -0700 From: Colin Percival User-Agent: Thunderbird 2.0.0.17 (X11/20081002) MIME-Version: 1.0 To: Christoph Mallon References: <49C4C974.5050209@gmx.de> <20090321130332.GD67783@alchemy.franken.de> <49C5737F.1050902@gmx.de> <20090321.175756.-434257642.imp@bsdimp.com> <49C5F88C.3070600@freebsd.org> <49C5FCCA.5010509@gmx.de> In-Reply-To: <49C5FCCA.5010509@gmx.de> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, marius@alchemy.franken.de Subject: Re: svn commit: r190098 - in head/sys/sparc64: fhc sparc64 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2009 09:19:02 -0000 Christoph Mallon wrote: > (two loops plus three if ()s, which can easily > happen in a non-trivial algorithm, and you start at column 48 of 80) I've found that this is usually a very good point at which to ask myself if the code in question can be refactored. I'm not saying that I refactor code just to make it fit into an 80 character width -- it's just that I often don't notice how complex a routine is getting while I'm writing it, unless I have some external prompt; and finding that I'm wrapping lots of lines provides exactly the sort of reminder I need. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid