Date: Thu, 10 Apr 2003 11:19:00 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/an if_an.c if_an_isa.c if_an_pccard.c if_an_pci.c Message-ID: <Pine.BSF.4.21.0304101114320.31875-100000@root.org> In-Reply-To: <20030410051257.D296537B408@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 9 Apr 2003, Warner Losh wrote: > Modified files: > sys/dev/an if_an.c if_an_isa.c if_an_pccard.c > if_an_pci.c > Log: > Don't lock in the attach routine. It isn't required. Register the > interrupt handler last. This gets rid of the sleep while locked > messages. > > Reviewed by: ambrisko This is nice. > @@ -817,9 +806,11 @@ > */ > ether_ifattach(ifp, sc->arpcom.ac_enaddr); > callout_handle_init(&sc->an_stat_ch); > - AN_UNLOCK(sc); > > return(0); > +fail:; > + mtx_destroy(&sc->an_mtx); > + return(error); > } > > static void Extra ; after "fail:" > @@ -176,18 +176,26 @@ > an_alloc_port(dev, sc->port_rid, AN_IOSIZ); > an_alloc_irq(dev, sc->irq_rid, 0); You should probably check the return values of these. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0304101114320.31875-100000>