From owner-svn-src-all@freebsd.org Tue Mar 14 22:28:35 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B062ED0D79E; Tue, 14 Mar 2017 22:28:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qk0-x230.google.com (mail-qk0-x230.google.com [IPv6:2607:f8b0:400d:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6D1041462; Tue, 14 Mar 2017 22:28:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qk0-x230.google.com with SMTP id v127so73589qkb.2; Tue, 14 Mar 2017 15:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G8A1aqI6MBm2ti4S6EcmtBdr9RLyYWH6B8vYa9YIPX0=; b=l4jTUP6dA8T/d4aXAzisoDeHG54fm71fRzTQ6RHkY0L1jDp5H+PON0HkOWloK+cbCw ftls7w8ErFs2oiPAfT49MYMBn1+q3mo4OJlzc4ge6xJyJgA9pWmIw3TvlS5DqmuSxpPW gn9K0BdI2NWPPqLNLbPeTTF4pEkNrHMrNpHbM+UvDZOf0h90McIkEs+wVOfOjgmmY4m3 IMlbfyIRboNQV0+hSt5XdMpDahmsLIb4C6m0r4+aWvaAwlCvgomyNF8i4ebYaO+Jhcy2 bCict40uURXoa/fx2ZaQ5hPrgz32hC82UIb8haO2X/xXbAG/Cl6qaeOKwjK28ITjNHU+ eqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G8A1aqI6MBm2ti4S6EcmtBdr9RLyYWH6B8vYa9YIPX0=; b=j8lODSx8vmKR8L6BwtZLK7RyfS3Oj4WSZUVCnE+pL+uc+O1HRsrTMfi5sB9bwG7Ik5 z4BRszaaftm+sckvjETddENhwVPQ7GDNk2bWQO4cF1RHUp8SBCEDcYUPUr06KO5hsbzM 69z8FKRCNgzFc1viE+UEDAhgwqAJpQaBAH/KFbY5cCNSrAB8pxQyUwjhXrLE/vbitEzg 0oUGwfV9icGqqaWnfMKo2dFubVaOXDtjjzuINJSSNPt6L7ii4QyFHt0limMem0p/Dock Og/LNBR3sttg0hPdQm4JlTIGAgssbniyWr2YXYZAmMrmuk/J5sTxO8uP0TcMmANcy+Dk UgSw== X-Gm-Message-State: AFeK/H2bQCOqYmTHk7yHe+7nSwq02xmG8iWC6y9qImmUOiSJFZ9cH8NppqLm7GkJeeSAL1MLYjmrEQDFhV6WBw== X-Received: by 10.55.67.135 with SMTP id q129mr39625qka.98.1489530514530; Tue, 14 Mar 2017 15:28:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.104.200 with HTTP; Tue, 14 Mar 2017 15:28:34 -0700 (PDT) In-Reply-To: <201703141827.v2EIRmLv080307@repo.freebsd.org> References: <201703141827.v2EIRmLv080307@repo.freebsd.org> From: Ngie Cooper Date: Tue, 14 Mar 2017 15:28:34 -0700 Message-ID: Subject: Re: svn commit: r315277 - in head/sys: dev/cxgb/ulp/iw_cxgb netinet To: Eric van Gyzen Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 22:28:35 -0000 On Tue, Mar 14, 2017 at 11:27 AM, Eric van Gyzen wrote: > Author: vangyzen > Date: Tue Mar 14 18:27:48 2017 > New Revision: 315277 > URL: https://svnweb.freebsd.org/changeset/base/315277 > > Log: > KTR: log IPv4 addresses in hex rather than dotted-quad > > When I made the changes in r313821, I fell victim to one of the > classic blunders, the most famous of which is: never get involved > in a land war in Asia. But only slightly less well known is this: > Keep your brain turned on and engaged when making a tedious, sweeping, > mechanical change. KTR can correctly log the immediate integral values > passed to it, as well as constant strings, but not non-constant strings, > since they might change by the time ktrdump retrieves them. Love the Princess Bride reference :). Some might say, bugs like this are, "Inconceivable!" Take care! -Ngie