From owner-svn-src-all@FreeBSD.ORG Thu Jan 1 04:55:53 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 980EDE83 for ; Thu, 1 Jan 2015 04:55:53 +0000 (UTC) Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 62A4B67369 for ; Thu, 1 Jan 2015 04:55:53 +0000 (UTC) Received: by mail-pa0-f53.google.com with SMTP id kq14so21909346pab.26 for ; Wed, 31 Dec 2014 20:55:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=FcmozSK/SaxGxJKauNziApNJgGi4075G7aV8GmSmY7M=; b=UIDPxlnaSsb/AYmDMm1/89kZpvHSXdiwQBzR0tdFcjSMs/zNJlcukGQRdwRjHoFaLW pOlC+ZqdDHeRL33G42DLDBw/F1zUU6CRtZuqJjadcZqzRiwzUogOQQOwAi6GJLnZrBph FS5Ggdf9L2msBdLLu/R6Y8w75Jg+4kzYo6h+PckOEhJFfdtL8GMbeV7rW4jAVYhuKAAa mZ2Qb/tMESxG31XefBBBaVnwWlX7RTiCKo7BWepJpC+pssOhkTYhQDmU8xrqCKjFxyH6 VG4YuDmMjyNsZ8Te3ofeQIkQihHKaAZGllcFxplRfnCops6C60dcoaA3wWvNqLIyG2Fv 7AJg== X-Gm-Message-State: ALoCoQkjNfyEB9/uoeK02d3UpASJr7ZiMaOP7dwNUIa3If2/1t04vbMbMApqkOAjDnQHiGrqMVcZ X-Received: by 10.70.61.37 with SMTP id m5mr111719854pdr.29.1420086355771; Wed, 31 Dec 2014 20:25:55 -0800 (PST) Received: from [10.64.25.37] ([69.53.236.236]) by mx.google.com with ESMTPSA id dn2sm21485219pdb.12.2014.12.31.20.25.53 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 31 Dec 2014 20:25:54 -0800 (PST) Sender: Warner Losh Subject: Re: svn commit: r276488 - in head: share/mk sys/arm/broadcom/bcm2835 sys/conf Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: multipart/signed; boundary="Apple-Mail=_A5BB1A90-23A6-4E51-9241-C1451572A585"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b3 From: Warner Losh In-Reply-To: Date: Wed, 31 Dec 2014 21:25:51 -0700 Message-Id: References: <201501010200.t01205Ge007058@svn.freebsd.org> <760D3407-921D-4249-9DC2-74610FA46920@FreeBSD.org> <27B917EC-CB35-4BF6-AB8F-4CBF56EC3E41@bsdimp.com> To: Garrett Cooper X-Mailer: Apple Mail (2.1993) Cc: svn-src-head@freebsd.org, Warner Losh , svn-src-all@freebsd.org, src-committers , Dimitry Andric X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jan 2015 04:55:53 -0000 --Apple-Mail=_A5BB1A90-23A6-4E51-9241-C1451572A585 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 > On Dec 31, 2014, at 9:15 PM, Garrett Cooper = wrote: >=20 > On Dec 31, 2014, at 20:12, Warner Losh wrote: >=20 >>> On Dec 31, 2014, at 8:52 PM, Dimitry Andric wrote: >>>=20 >>> On 01 Jan 2015, at 03:00, Warner Losh wrote: >>>>=20 >>>> Author: imp >>>> Date: Thu Jan 1 02:00:04 2015 >>>> New Revision: 276488 >>>> URL: https://svnweb.freebsd.org/changeset/base/276488 >>>>=20 >>>> Log: >>>> Fix module builds on arm (and maybe others) by turning off a whole >>>> raft of new warnings that appear to be on by default in clang = 3.5.0. >>>> Fix RPI-B build issues with new clang not liking the ability to = pass >>>> arbitrary flags to as, since some flags are more arbitrary (and = thus >>>> verboten) than others. >>>>=20 >>>> These warnings should be actually fixed in the code, but this is a >>>> band-aide to get things (almost) building again. >>>>=20 >>>> Modified: >>>> head/share/mk/bsd.kmod.mk >>>> head/share/mk/bsd.sys.mk >>>> head/sys/arm/broadcom/bcm2835/std.bcm2835 >>>> head/sys/conf/kern.mk >>>>=20 >>>> Modified: head/share/mk/bsd.kmod.mk >>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>> --- head/share/mk/bsd.kmod.mk Thu Jan 1 01:43:00 2015 = (r276487) >>>> +++ head/share/mk/bsd.kmod.mk Thu Jan 1 02:00:04 2015 = (r276488) >>>> @@ -13,5 +13,3 @@ SYSDIR=3D ${_dir} >>>> .endif >>>>=20 >>>> .include "${SYSDIR}/conf/kmod.mk" >>>> - >>>> -.include >>>>=20 >>>> Modified: head/share/mk/bsd.sys.mk >>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>> --- head/share/mk/bsd.sys.mk Thu Jan 1 01:43:00 2015 = (r276487) >>>> +++ head/share/mk/bsd.sys.mk Thu Jan 1 02:00:04 2015 = (r276488) >>>> @@ -110,11 +110,7 @@ CWARNFLAGS+=3D -Wno-format >>>> CWARNFLAGS+=3D -Wno-unknown-pragmas >>>> .endif # IGNORE_PRAGMA >>>>=20 >>>> -.if ${COMPILER_TYPE} =3D=3D "clang" >>>> -# Would love to do this unconditionally, but can't due to its use = in >>>> -# kernel build coupled with CFLAGS.${TARGET} feature >>>> CLANG_NO_IAS=3D -no-integrated-as >>>> -.endif >>>> CLANG_OPT_SMALL=3D -mstack-alignment=3D8 -mllvm = -inline-threshold=3D3\ >>>> -mllvm -simplifycfg-dup-ret -mllvm -enable-gvn=3Dfalse >>>> CFLAGS.clang+=3D -Qunused-arguments >>>=20 >>> This should not be removed from bsd.sys.mk, since other things = depend on >>> it, are you sure that you want this? :) >>=20 >> I may be wrong here for boot stuff that uses it. >>=20 >>> As far as I know, there are still a few places in the tree that use = the >>> CLANG_NO_IAS macro. It would be nice if those all went away, = though=85 >>=20 >> Only for boot. Thanks, though I think they may be CFLAGS.clang +=3D = there. >>=20 >>> Modified: head/sys/arm/broadcom/bcm2835/std.bcm2835 >>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>> --- head/sys/arm/broadcom/bcm2835/std.bcm2835 Thu Jan 1 = 01:43:00 2015 (r276487) >>>> +++ head/sys/arm/broadcom/bcm2835/std.bcm2835 Thu Jan 1 = 02:00:04 2015 (r276488) >>>> @@ -2,7 +2,7 @@ >>>>=20 >>>> machine arm armv6 >>>> cpu CPU_ARM1176 >>>> -makeoptions CONF_CFLAGS=3D"-mcpu=3Darm1176jzf-s = -Wa,-mcpu=3Darm1176jzf-s" >>>> +makeoptions CONF_CFLAGS=3D"-mcpu=3Darm1176jzf-s" >>>>=20 >>>> files "../broadcom/bcm2835/files.bcm2835" >>>>=20 >>>>=20 >>>> Modified: head/sys/conf/kern.mk >>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>> --- head/sys/conf/kern.mk Thu Jan 1 01:43:00 2015 = (r276487) >>>> +++ head/sys/conf/kern.mk Thu Jan 1 02:00:04 2015 = (r276488) >>>> @@ -164,4 +164,26 @@ CFLAGS+=3D -fstack-protector >>>> CFLAGS+=3D -gdwarf-2 >>>> .endif >>>>=20 >>>> +# A whole bunch of new default warnings in clang 3.5 subpress for = now until >>>> +# this can be cleaned up. >>>> +.if ${COMPILER_VERSION} >=3D 30500 >>>> +CFLAGS.clang+=3D -Wno-pointer-sign -Wno-constant-conversion = -Wno-format \ >>>> + -Wno-shift-count-negative -Wno-tautological-pointer-compare \ >>>> + -Wno-shift-count-overflow -Wno-tautological-compare >>>> +.endif >>>> + >>>> CFLAGS+=3D ${CFLAGS.${COMPILER_TYPE}} >>>=20 >>> Note that for x86, all of these warnings were already either fixed = or >>> suppressed. I assume this will be fleshed out later? >>=20 >> Yea, but since a build universe wasn=92t done, they were present in = the >> build. They are harmless on other architectures. >>=20 >>>> +# Tell bmake not to mistake standard targets for things to be = searched for >>>> +# or expect to ever be up-to-date. >>>> +PHONY_NOTMAIN =3D afterdepend afterinstall all beforedepend = beforeinstall \ >>>> + beforelinking build build-tools buildfiles buildincludes = \ >>>> + checkdpadd clean cleandepend cleandir cleanobj configure = \ >>>> + depend dependall distclean distribute exe \ >>>> + html includes install installfiles installincludes lint = \ >>>> + obj objlink objs objwarn realall realdepend \ >>>> + realinstall regress subdir-all subdir-depend = subdir-install \ >>>> + tags whereobj >>>> + >>>> +.PHONY: ${PHONY_NOTMAIN} >>>> +.NOTMAIN: ${PHONY_NOTMAIN} >>>>=20 >>>=20 >>> Was this latter part intentional? It does not seem to have anything = to >>> do with clang at all. >>=20 >> It was the only bit of bsd.sys.mk that was needed. >=20 > Unfortunately that broke the build on all architectures where = bce is built as -std=3D was not being passed to the compiler. Jenkins = reported an error with bce: = https://jenkins.freebsd.org/job/FreeBSD_HEAD_sparc64/225/changes , and I = committed a change to bring back that support here: = https://svnweb.freebsd.org/changeset/base/276493 . Please revert it if = it wasn=92t correct. This change is wrong. bsd.sys.mk was eliminated on purpose, dammit. Warner --Apple-Mail=_A5BB1A90-23A6-4E51-9241-C1451572A585 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUpMxQAAoJEGwc0Sh9sBEAVVsQAOP9uJYBSw8fu9WJMIXW3VES FpzjAnFjdg50/AvQfGU2XJc5tR3SLS7Z6KAf4RSKW3l6BYnUoqHZqhq7stE0za27 ex0OdEAHoBp7TAYXSrG6L77TROcOMiyA+ZgMcfZ1tY33Z8LSpxeqPEej0esxlLJ1 FKAzDWbgTBeOL90ORmcq34sre6Pev34WQL4gqEHOEVMF9J/DC5XrCRTVFzn/s/H9 cXxOwTDc22CF0BCN2k11fuzwRqE+iYVguLCwOee3y1Wxm0hraAlv6lhvZFbwBuW4 StXy/Rd2pn9AvZTQmyKLjXt9muTNNn7BeYaObr6HTJ26vgixWC8H4V6pCXo2WTHA TcQxFdDBvaamilgi5OgINa2146sCpWSFtMFr0FdttPfCP9///dDppbZcw0qfYtsH blrI4aXgW3F8zHKWbJqvkNA7BHALu/H6fScInymymkw/9Q7hjirq7+BWoDQyLkPo Cz4Z1ULwXfzI3cNGlVvbIFvTapQa+UPGcKs9f/sWiwFtRonyffmnF6M99g6DcUW5 Hd+WCDWafeyTZHoSh9U/1ZG63vKAzJjCxZSILiFYT3PwXyEeaYjum5qXxevsyghO 0/dJJJKE1TcORdd9kjQvo03umTJWmw7lbxQ4YPNYkrUO7+isSk5EoapcQcXIYuDF Cs7tDnJhbr+oDUvq0i9e =blje -----END PGP SIGNATURE----- --Apple-Mail=_A5BB1A90-23A6-4E51-9241-C1451572A585--