From owner-cvs-all@FreeBSD.ORG Fri Oct 19 08:53:16 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6BB7E16A420; Fri, 19 Oct 2007 08:53:16 +0000 (UTC) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E589D13C4EA; Fri, 19 Oct 2007 08:53:15 +0000 (UTC) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J8rF0E095906; Fri, 19 Oct 2007 08:53:15 GMT (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J8rFRc095905; Fri, 19 Oct 2007 08:53:15 GMT (envelope-from silby) Message-Id: <200710190853.l9J8rFRc095905@repoman.freebsd.org> From: Mike Silbersack Date: Fri, 19 Oct 2007 08:53:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet tcp_syncache.c tcp_usrreq.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 08:53:16 -0000 silby 2007-10-19 08:53:15 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c tcp_usrreq.c Log: Pick the smallest possible TCP window scaling factor that will still allow us to scale up to sb_max, aka kern.ipc.maxsockbuf. We do this because there are broken firewalls that will corrupt the window scale option, leading to the other endpoint believing that our advertised window is unscaled. At scale factors larger than 5 the unscaled window will drop below 1500 bytes, leading to serious problems when traversing these broken firewalls. With the default maxsockbuf of 256K, a scale factor of 3 will be chosen by this algorithm. Those who choose a larger maxsockbuf should watch out for the compatiblity problems mentioned above. Reviewed by: andre Revision Changes Path 1.131 +17 -6 src/sys/netinet/tcp_syncache.c 1.164 +1 -2 src/sys/netinet/tcp_usrreq.c