Date: Wed, 23 Dec 2015 14:50:57 +0800 (WITA) From: Gerald Pfeifer <gerald@pfeifer.com> To: Antoine Brodin <antoine@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r397956 - in head: devel/ccache lang/gcc lang/gcc46 lang/gcc47 lang/gcc48 lang/gcc49 lang/gcc5 lang/gcc5-devel lang/gcc6-devel Message-ID: <alpine.LSU.2.11.1510011112451.9339@linux-irjp.site> In-Reply-To: <201509261103.t8QB3JLo008166@repo.freebsd.org> References: <201509261103.t8QB3JLo008166@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 26 Sep 2015, Antoine Brodin wrote: > Log: > Remove deprecated @exec/@unexec from ports using ccache-update-links > > Modified: > head/devel/ccache/pkg-plist > head/lang/gcc/pkg-plist > head/lang/gcc46/pkg-plist > head/lang/gcc47/pkg-plist > head/lang/gcc48/pkg-plist > head/lang/gcc49/pkg-plist > head/lang/gcc5-devel/pkg-plist > head/lang/gcc5/pkg-plist > head/lang/gcc6-devel/pkg-plist It would have been nice to give me a heads up. After all, 8 of 9 of these ports list me as maintainer. Not to be territorial, but together we certainly could have improved the log message (which talks about removing @exec/@unexec when in fact it only replaces them by @postexec/@preunexec. Plus, after these changes portlint now complained when it did not before. WARN: /home/gerald/ports/lang/gcc6-devel/pkg-plist: [76]: unknown pkg-plist directive "@postexec if type ccache-update-links >/dev/null 2>&1; then ccache-update-links -v; fi" WARN: /home/gerald/ports/lang/gcc6-devel/pkg-plist: [77]: unknown pkg-plist directive "@postunexec if type ccache-update-links >/dev/null 2>&1; then ccache-update-links -v; fi" At a minimum, I would have expected you to file a PR against portlint, which Olli beat me to ( https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204900 ) Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.11.1510011112451.9339>