From owner-svn-ports-all@freebsd.org Wed Dec 23 06:59:55 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9ABD1A500F5; Wed, 23 Dec 2015 06:59:55 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7A0CB13B0; Wed, 23 Dec 2015 06:59:54 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from [10.10.10.169] (unknown [180.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ainaz.pair.com (Postfix) with ESMTPSA id 18CF03F450; Wed, 23 Dec 2015 01:51:37 -0500 (EST) Date: Wed, 23 Dec 2015 14:50:57 +0800 (WITA) From: Gerald Pfeifer To: Antoine Brodin cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r397956 - in head: devel/ccache lang/gcc lang/gcc46 lang/gcc47 lang/gcc48 lang/gcc49 lang/gcc5 lang/gcc5-devel lang/gcc6-devel In-Reply-To: <201509261103.t8QB3JLo008166@repo.freebsd.org> Message-ID: References: <201509261103.t8QB3JLo008166@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Dec 2015 06:59:55 -0000 On Sat, 26 Sep 2015, Antoine Brodin wrote: > Log: > Remove deprecated @exec/@unexec from ports using ccache-update-links > > Modified: > head/devel/ccache/pkg-plist > head/lang/gcc/pkg-plist > head/lang/gcc46/pkg-plist > head/lang/gcc47/pkg-plist > head/lang/gcc48/pkg-plist > head/lang/gcc49/pkg-plist > head/lang/gcc5-devel/pkg-plist > head/lang/gcc5/pkg-plist > head/lang/gcc6-devel/pkg-plist It would have been nice to give me a heads up. After all, 8 of 9 of these ports list me as maintainer. Not to be territorial, but together we certainly could have improved the log message (which talks about removing @exec/@unexec when in fact it only replaces them by @postexec/@preunexec. Plus, after these changes portlint now complained when it did not before. WARN: /home/gerald/ports/lang/gcc6-devel/pkg-plist: [76]: unknown pkg-plist directive "@postexec if type ccache-update-links >/dev/null 2>&1; then ccache-update-links -v; fi" WARN: /home/gerald/ports/lang/gcc6-devel/pkg-plist: [77]: unknown pkg-plist directive "@postunexec if type ccache-update-links >/dev/null 2>&1; then ccache-update-links -v; fi" At a minimum, I would have expected you to file a PR against portlint, which Olli beat me to ( https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204900 ) Gerald