From owner-freebsd-audit  Sun Jun  9 18:33:48 2002
Delivered-To: freebsd-audit@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id BF81137B403; Sun,  9 Jun 2002 18:33:44 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id LAA29436;
	Mon, 10 Jun 2002 11:33:37 +1000
Date: Mon, 10 Jun 2002 11:34:25 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Giorgos Keramidas <keramida@FreeBSD.ORG>
Cc: audit@FreeBSD.ORG
Subject: Re: Compiling bin/ed with WARNS=6
In-Reply-To: <20020610004914.GA10811@hades.hell.gr>
Message-ID: <20020610112448.G1757-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Mon, 10 Jun 2002, Giorgos Keramidas wrote:

> There are only two small changes that need to be done to ed(1) to make
> it compile cleanly with WARNS=6 in i386/CURRENT.  I have tested the
> ...
> Declare an array of bytes as `char[]' and not `unsigned char[]'.

Er, this seems to break at least get_des_char() if the buffer contains
negative chars.  E.g., the signed char that has the value EOF (if any)
would be indistinguishable from EOF.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message